Fix and add test in LevelComponent on the server side. #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great work, we definitely need more tests, so I was very happy to see this pull request 😄 |
schmatz
added a commit
that referenced
this pull request
Jan 12, 2014
Fix and add test in LevelComponent on the server side.
|
Wow, double amazing! |
|
Adding tests, I understand better Code Combat. Changing only the tests, I do not risk breaking something. Thank you. |
|
@smoratinos Can you shoot an email to nick@codecombat.com? We have a little fun thing for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
3 tests, 7 assertions, 3 failures
After
10 tests, 61 assertions, 0 failures