8000 Update single class topbar design by gabriellui1 · Pull Request #7572 · codecombat/codecombat · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update single class topbar design #7572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 10, 2024
Merged

Update single class topbar design #7572

merged 3 commits into from
Jul 10, 2024

Conversation

gabriellui1
Copy link
Collaborator
@gabriellui1 gabriellui1 commented Jul 8, 2024 •
edited by coderabbitai bot
Loading

fixes ENG-902
image

Summary by CodeRabbit

  • New Features

    • Added conditional rendering for the "Add Students" button based on the showClassInfo value.
    • Improved control over the visibility of the licenses component with conditions based on showLicenses and showClassInfo.

  • Bug Fixes

    • Removed an unnecessary <img> tag for a cleaner UI appearance.

@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Jul 8, 2024 •
edited
Loading

Walkthrough

The TitleBar.vue component in the Teacher Dashboard has been updated to conditionally render the "Add Students" button and the licenses-component based on showClassInfo and showLicenses properties. These changes improve how certain elements are displayed depending on the application's state.

Changes

File Path Change Summary
ozaria/site/components/teacher-dashboard/common/... Added conditions for "Add Students" button and licenses-component rendering, removed <img> tag

Assessment against linked issues

Objective (Issue) Addressed Explanation
Change Add Students design and position (ENG-902) ✅

Poem

🐇 In the dashboard light so clear,
Buttons dance with conditions dear.
Students add, licenses show,
Only when the info flows.
Code refined, teachers cheer! 🚀

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Jul 8, 2024
View reviewed changes
Copy link
Contributor
@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between c2f2e4b and 6ab0a16.

Files selected for processing (1)
  • ozaria/site/components/teacher-dashboard/common/TitleBar.vue (3 hunks)
Additional comments not posted (2)
ozaria/site/components/teacher-dashboard/common/TitleBar.vue (2)

199-202: Conditional Rendering of licenses-component Approved

The licenses-component is now conditionally rendered based on both showLicenses and showClassInfo. This change appears to be correctly implemented and aligns with the new design requirements.

239-248: Conditional Rendering of "Add Students" Button Approved

The "Add Students" button is now conditionally rendered based on the value of showClassInfo. The inclusion of the <span> tag for displaying the text "Add Students" is correctly implemented and aligns with the new design requirements.

mrfinch
mrfinch reviewed Jul 9, 2024
View reviewed changes
ozaria/site/components/teacher-dashboard/common/TitleBar.vue Outdated
@@ -211,7 +196,7 @@ export default {
</div>
<!-- we want to use classroom ownerID always even when class is not owned by teacher in case of shared classes since license is cut from owner -->
<licenses-component
v-if="showLicenses"
v-if="showLicenses && !showClassInfo"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually need this still. I mentioned only change Add Students 😅

ozaria/site/components/teacher-dashboard/common/TitleBar.vue Outdated
@@ -246,10 +231,22 @@ export default {
</primary-button>

<button-curriculum-guide
v-if="!showClassInfo"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's not do it till we get this done: https://linear.app/codecombat/issue/ENG-781/curriculum-tab

Also, we would want it to be removed from all pages when do the movement to sidebar

coderabbitai[bot]
coderabbitai bot reviewed Jul 9, 2024
View reviewed changes
Copy link
Contributor
@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 6ab0a16 and ec8aee4.

Files selected for processing (1)
  • ozaria/site/components/teacher-dashboard/common/TitleBar.vue (2 hunks)
Files skipped from review as they are similar to previous changes (1)
  • ozaria/site/components/teacher-dashboard/common/TitleBar.vue

@mrfinch mrfinch merged commit a699c95 into master Jul 10, 2024
1 of 2 checks passed
@mrfinch mrfinch deleted the gabriel/update-single-class-topbar-design branch July 10, 2024 07:33
@coderabbitai coderabbitai bot mentioned this pull request Sep 27, 2024
Merged
@coderabbitai coderabbitai bot mentioned this pull request Apr 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@mrfinch mrfinch mrfinch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabriellui1 @mrfinch
0