8000 Change APCSP form to send inquries to sales by gabriellui1 · Pull Request #7710 · codecombat/codecombat · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Change APCSP form to send inquries to sales #7710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 20, 2024
Merged

Change APCSP form to send inquries to sales #7710

merged 2 commits into from
Sep 20, 2024

Conversation

gabriellui1
Copy link
Collaborator
@gabriellui1 gabriellui1 commented Sep 17, 2024 •
edited by coderabbitai bot
Loading

fixes ENG-1134

Summary by CodeRabbit

  • New Features

    • Enhanced modal handling for licensing requests and contact inquiries, improving user interactions.
    • Introduced a dedicated modal for requesting access to the course.

  • Improvements

    • Improved clarity of modal actions with renamed variables for better user experience.
    • Updated the contact button to activate a more relevant modal for license inquiries.

@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Sep 17, 2024 •
edited
Loading

Walkthrough

The changes in this pull request focus on enhancing the modal handling logic within the PageMarketing.vue file. The variable showModal has been replaced with showRequestModal and showContactModal to clarify the purpose of each modal. The button actions for requesting access and contacting have been updated to trigger the corresponding modals, and new modal components have been introduced to improve semantic clarity and user experience.

Changes

File Change Summary
app/views/apcsp/PageMarketing.vue - Added modal-get-licenses
- Replaced modal-apcsp-contact with modal-get-licenses
- Renamed showModal to showContactModal
- Renamed showModal to showRequestModal

Assessment against linked issues

Objective Addressed Explanation
Change AP CSP Form to send inquiries to sales@codecombat.com (ENG-1134) ❓ It is unclear if the form submission logic was updated.

Possibly related PRs

Poem

🐇 In the land of code where rabbits play,
Modals now dance in a clearer way.
Request and contact, each has its space,
With buttons that guide us, a joyful embrace!
Hooray for the changes, let’s hop and cheer,
For clearer modals bring us all near! 🥕

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between c11a3e8 and f184db8.

Files selected for processing (1)
  • app/views/apcsp/PageMarketing.vue (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • app/views/apcsp/PageMarketing.vue

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@gabriellui1 gabriellui1 changed the title Change apcsp form to send inquries to sales Change APCSP form to send inquries to sales Sep 17, 2024
mrfinch
mrfinch reviewed Sep 18, 2024
View reviewed changes
app/views/apcsp/PageMarketing.vue Outdated
@@ -207,21 +207,25 @@
.col-md-6
.question {{ $t('apcsp_marketing.question_3') }}
.answer(v-html="$t('apcsp_marketing.answer_3', i18nData)")
modal-apcsp-contact(v-if="showModal" @close="showModal = false")
modal-get-licenses(v-if="showRequestModal" @close="showRequestModal = false" :subtitle="'Let us know if you have any questions or requests regarding our AP CSP curriculum.'")
modal-apcsp-contact(v-if="showContactModal" @close="showContactModal = false")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we dont want to use this modal in any case. Let's just use the modal-get-licenses only

@mrfinch mrfinch merged commit e06c801 into master Sep 20, 2024
1 of 2 checks passed
@mrfinch mrfinch deleted the gabriel/send-apcsp-inquries-to-sales branch September 20, 2024 23:11
@coderabbitai coderabbitai bot mentioned this pull request Sep 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrfinch mrfinch mrfinch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabriellui1 @mrfinch
0