8000 remove parent home account sign up temporarily by mrfinch · Pull Request #7949 · codecombat/codecombat · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

remove parent home account sign up temporarily #7949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 27, 2025
Merged

remove parent home account sign up temporarily #7949

merged 1 commit into from
Mar 27, 2025

Conversation

mrfinch
Copy link
Contributor
@mrfinch mrfinch commented Mar 26, 2025 •
edited by coderabbitai bot
Loading

fixes ENG-1695

Summary by CodeRabbit

  • New Features

    • Landing page now displays tailored content based on user status, offering distinct prompts for anonymous users and registered users with subscription options.

  • Style

    • Refined signup prompt text for improved clarity.
    • Enhanced button presentation and layout through updated styling adjustments.

@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Mar 26, 2025 •
edited
Loading

Walkthrough

This pull request updates the user interface and text content. In the localization file, the signup description is modified to update its capitalization. In the parents landing page component, conditional rendering is introduced to display different call-to-action buttons based on whether a user is anonymous or a registered non-premium user. Additionally, new CSS classes are added for styling adjustments.

Changes

File(s) Change Summary
app/locale/en.js Updated signup_description in the ozaria_home section from 'sign up for self-paced access' to 'Sign Up for Self-Paced Access'.
app/views/landing-pages/parents-v2/PageParents.vue Introduced conditional rendering in the column-two template: anonymous users see a CTA button linking with data-start-on-path="individual", while registered non-premium users see a different CTA that calls openSubscribeModal on click. Added new CSS classes .lowercase and .column-one for styling.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant P as PageParents.vue
    participant CTA as CTAButton
    U->>P: Load Parents landing page
    alt User is Anonymous
        P->>CTA: Render sign-up button (individual path)
    else User is Registered Home (non-premium)
        P->>CTA: Render subscription button
        CTA->>P: On click, trigger openSubscribeModal()
    end
Loading

Assessment against linked issues

Objective Addressed Explanation
Remove parents signup page flow (ENG-1695) ✅

Possibly related PRs

Poem

In the code-field, I hop with delight,
Shaping buttons and text so bright.
Anonymous or registered, the path is clear,
With toggled flows our message is near!
🐇 Happy hops in every line of code!

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0c2358d and 723e77f.

📒 Files selected for processing (2)
  • app/locale/en.js (1 hunks)
  • app/views/landing-pages/parents-v2/PageParents.vue (4 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Node.js CI (18.10.0)
🔇 Additional comments (6)
app/locale/en.js (1)

6246-6246: Text capitalization improved for signup CTA.

The capitalization change to "Sign Up for Self-Paced Access" follows proper title case conventions, which is appropriate for a call-to-action button. This change aligns with the UI modifications in PageParents.vue mentioned in the summary, where conditional rendering for different user states has been implemented.

Note that this text change alone doesn't disable the signup functionality - that implementation must be in the related component files.

app/views/landing-pages/parents-v2/PageParents.vue (5)

33-47: Conditional rendering for anonymous users looks good.

This implementation correctly shows the signup button only to anonymous users with appropriate data attributes, aligning with the PR objective to temporarily disable parent home account signup.

48-57: Good addition of subscription option for registered non-premium users.

This provides a clear upgrade path for registered home users who aren't premium yet, showing them a subscription button instead of the signup option.

201-214: Consistent implementation of conditional signup description.

The signup description in the footer CTA is now also conditional, showing only to anonymous users, which maintains consistency with the changes above.

777-779: Minor styling addition for consistent text formatting.

The lowercase class ensures consistent text styling for the signup button text.

844-846: Layout improvement for column alignment.

Centering items in the column-one class helps maintain visual balance in the two-column layout.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mrfinch mrfinch merged commit 8203daa into master Mar 27, 2025
3 checks passed
@mrfinch mrfinch deleted the saurabh/parents branch March 27, 2025 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mrfinch
0