Biome install #66
Merged
Biome install #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
coco-wizard
requested changes
Mar 5, 2025
There was a problem hiding this comment.
Looks good! Good work Nathan, thank you.
My only comments on this is if you could add a biome.json file? This will ensure all formatting is centralized (and not varying based on IDE-specific Biome extension settings).
I believe the command pnpm biome init should do it. Thank you!
|
Gotcha-thought I had a biome.json but I'll add if it's missing when i get a moment |
|
So @coco-wizard -- running biome in the previous config defaults to the default biome.json, but doesn't save it if you don't want it. I added the biome.json so we can modify parameters as needed. pushing commit now! |
coco-wizard
approved these changes
Mar 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Biome is installed on the project! Changes in this PR:
.gitignoreto not track mac filesystem stuffNote that the CI workflow will not reformat code if it detects errors -- this possibility was tossed around but after hours of wrestling GitHub actions with no result, I gave in and setup husky instead.