🐛 Use config-set token as CLI default fallback #464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just like in the old days... Before this patch, the v4-related rewrite of the Codecov uploader CLI lost the ability to use the token set in the config file [[1]]. This change fixes the regression recovering the original behavior. The bug has been discovered during the re-configuration of ``codecov/codecov-action`` in ``pytest-dev/pytest``. We use the clear-text token to improve stability of uploads in PRs from forks so it makes sense to keep it in the config rather than in the GitHub Actions CI/CD definition file. [1]: https://docs.codecov.com/docs/codecovyml-reference#codecovtoken 8000
|
Hey @thomasrockhu-codecov, I've found another v4 regression FYI ^ |
This was referenced Jun 25, 2024
|
@joseph-sentry @giovanni-guidini any chance any of you could trigger the CI? |
joseph-sentry
approved these changes
Jun 26, 2024
|
I was confused by these failures on |
|
@joseph-sentry @thomasrockhu-codecov would you mind making a new release with this patch included? |
webknjaz
added a commit
to aio-libs/yarl
that referenced
this pull request
Jun 27, 2024
This duplicates the effort of the config file temporarily. It should get reverted once codecov/codecov-cli#464 is released.
|
@webknjaz a new release ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just like in the old days... Before this patch, the v4-related rewrite of the Codecov uploader CLI lost the ability to use the token set in the config file [1]. This change fixes the regression recovering the original behavior.
The bug has been discovered during the re-configuration of
codecov/codecov-actioninpytest-dev/pytest. We use the clear-text token to improve stability of uploads in PRs from forks so it makes sense to keep it in the config rather than in the GitHub Actions CI/CD definition file.