8000 Remove unused `update_archive` by Swatinem · Pull Request #683 · codecov/worker · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on May 5, 2025. It is now read-only.

Remove unused update_archive #683

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Remove unused update_archive #683

merged 2 commits into from
Sep 9, 2024

Conversation

Swatinem
Copy link
Contributor
@Swatinem Swatinem commented Sep 4, 2024

No description provided.

@Swatinem Swatinem self-assigned this Sep 4, 2024
@codecov-notifications
Copy link
codecov-notifications bot commented Sep 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

< 8000 a href="https://stage-app.codecov.dev/gh/codecov/worker/pull/683?src=pr&el=tree" rel="nofollow">Impacted file tree graph

@@            Coverage Diff             @@
##             main     #683      +/-   ##
==========================================
+ Coverage   98.08%   98.09%   +0.01%     
==========================================
  Files         434      432       -2     
  Lines       36743    36705      -38     
==========================================
- Hits        36038    36006      -32     
+ Misses        705      699       -6
Flag Coverage Δ
integration 98.09% <100.00%> (+0.01%) ⬆️
latest-uploader-overall 98.09% <100.00%> (+0.01%) ⬆️
unit 98.09% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.00% <100.00%> (+0.03%) ⬆️
OutsideTasks 98.09% <100.00%> (+0.02%) ⬆️
Files Coverage Δ
services/archive.py 99.06% <100.00%> (+4.10%) ⬆️

... and 6 files with indirect coverage changes

@codecov-qa
Copy link
codecov-qa bot commented Sep 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.09%. Comparing base (68d5a89) to head (06933a8).
Report is 11 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #683      +/-   ##
==========================================
+ Coverage   98.08%   98.09%   +0.01%     
==========================================
  Files         434      432       -2     
  Lines       36743    36705      -38     
==========================================
- Hits        36038    36006      -32     
+ Misses        705      699       -6
Flag Coverage Δ
integration 98.09% <100.00%> (+0.01%) ⬆️
latest-uploader-overall 98.09% <100.00%> (+0.01%) ⬆️
unit 98.09% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.00% <100.00%> (+0.03%) ⬆️
OutsideTasks 98.09% <100.00%> (+0.02%) ⬆️
Files with missing lines Coverage Δ
services/archive.py 99.06% <100.00%> (+4.10%) ⬆️

... and 6 files with indirect coverage changes

@codecov-public-qa Codecov Public QA
Copy link
codecov-public-qa bot commented Sep 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.09%. Comparing base (68d5a89) to head (06933a8).
Report is 5 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #683      +/-   ##
==========================================
+ Coverage   98.08%   98.09%   +0.01%     
==========================================
  Files         434      432       -2     
  Lines       36743    36705      -38     
==========================================
- Hits        36038    36006      -32     
+ Misses        705      699       -6
Flag Coverage Δ
integration 98.09% <100.00%> (+0.01%) ⬆️
latest-uploader-overall 98.09% <100.00%> (+0.01%) ⬆️
unit 98.09% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.00% <100.00%> (+0.03%) ⬆️
OutsideTasks 98.09% <100.00%> (+0.02%) ⬆️
Files Coverage Δ
services/archive.py 99.06% <100.00%> (+4.10%) ⬆️

... and 6 files with indirect coverage changes

@codecov Codecov
Copy link
codecov bot commented Sep 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.13%. Comparing base (68d5a89) to head (06933a8).
Report is 11 commits behind head on main.

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #683      +/-   ##
==========================================
+ Coverage   98.12%   98.13%   +0.01%     
==========================================
  Files         474      474              
  Lines       38069    38063       -6     
==========================================
- Hits        37356    37354       -2     
+ Misses        713      709       -4
Flag Coverage Δ
integration 98.09% <100.00%> (+0.01%) ⬆️
latest-uploader-overall 98.09% <100.00%> (+0.01%) ⬆️
unit 98.09% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.10% <100.00%> (+0.02%) ⬆️
OutsideTasks 98.09% <100.00%> (+0.02%) ⬆️
Files with missing lines Coverage Δ
services/archive.py Critical 99.06% <100.00%> (+4.06%) ⬆️

... and 6 files with indirect coverage changes

Related Entrypoints
run/app.tasks.upload.Upload
run/app.tasks.notify.Notify
run/app.tasks.timeseries.save_commit_measurements
run/app.tasks.pulls.Sync
run/app.tasks.compute_comparison.ComputeComparison
run/app.tasks.upload.UploadFinisher
run/app.tasks.upload.UploadProcessor
run/app.tasks.upload.PreProcessUpload
run/app.tasks.label_analysis.process_request

@Swatinem Swatinem requested a review from a team September 5, 2024 14:35
matt-codecov
matt-codecov approved these changes Sep 5, 2024
View reviewed changes
services/archive.py
"""
Boolean. True if enterprise, False if not.
A hash key of the repo for internal storage
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this comment in the wrong place?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess its the weird way that python doc comments work, as they appear (inside, or) after the item they are documenting

@Swatinem Swatinem added this pull request to the merge queue Sep 9, 2024
Merged via the queue into main with commit 3be215a Sep 9, 2024
25 of 27 checks passed
@Swatinem Swatinem deleted the swatinem/rm-updatearchive branch September 9, 2024 07:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matt-codecov matt-codecov matt-codecov approved these changes

@joseph-sentry joseph-sentry Awaiting requested review from joseph-sentry

Assignees

@Swatinem Swatinem

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Swatinem @matt-codecov
0