8000 Make lcov parser more accepting of corrupt coverage lines by Swatinem · Pull Request #726 · codecov/worker · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on May 5, 2025. It is now read-only.

Make lcov parser more accepting of corrupt coverage lines #726

Merged
merged 1 commit into from
Sep 19, 2024
8000
Merged

Make lcov parser more accepting of corrupt coverage lines #726

merged 1 commit into from
Sep 19, 2024

Conversation

Swatinem
Copy link
Contributor
@Swatinem Swatinem commented Sep 19, 2024 •
edited
Loading

fixes WORKER-JGW, fixes WORKER-JN4, fixes WORKER-JMY, fixes WORKER-JNY, fixes WORKER-PA7

@Swatinem Swatinem requested a review from a team September 19, 2024 13:04
@Swatinem Swatinem self-assigned this Sep 19, 2024
@Swatinem Swatinem enabled auto-merge September 19, 2024 13:06
@codecov-qa
Copy link
codecov-qa bot commented Sep 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 98.06%. Comparing base (95d0b4a) to head (29b1203).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
services/report/languages/lcov.py 93.87% 3 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #726      +/-   ##
==========================================
- Coverage   98.07%   98.06%   -0.01%     
==========================================
  Files         434      434              
  Lines       36764    36775      +11     
==========================================
+ Hits        36055    36065      +10     
- Misses        709      710       +1
Flag Coverage Δ
integration 98.06% <95.00%> (-0.01%) ⬇️
latest-uploader-overall 98.06% <95.00%> (-0.01%) ⬇️
unit 98.06% <95.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.95% <93.87%> (-0.01%) ⬇️
OutsideTasks 98.09% <95.00%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
services/report/languages/tests/unit/test_lcov.py 100.00% <100.00%> (ø)
services/report/languages/lcov.py 95.00% <93.87%> (-0.79%) ⬇️

@codecov-notifications
Copy link
codecov-notifications bot commented Sep 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.00000% with 3 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files Patch % Lines
services/report/languages/lcov.py 93.87% 3 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #726      +/-   ##
==========================================
- Coverage   98.07%   98.06%   -0.01%     
==========================================
  Files         434      434              
  Lines       36764    36775      +11     
==========================================
+ Hits        36055    36065      +10     
- Misses        709      710       +1
Flag Coverage Δ
integration 98.06% <95.00%> (-0.01%) ⬇️
latest-uploader-overall 98.06% <95.00%> (-0.01%) ⬇️
unit 98.06% <95.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.95% <93.87%> (-0.01%) ⬇️
OutsideTasks 98.09% <95.00%> (-0.01%) ⬇️
Files Coverage Δ
services/report/languages/tests/unit/test_lcov.py 100.00% <100.00%> (ø)
services/report/languages/lcov.py 95.00% <93.87%> (-0.79%) ⬇️

@codecov Codecov
Copy link
codecov bot commented Sep 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 98.11%. Comparing base (95d0b4a) to head (29b1203).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
services/report/languages/lcov.py 93.87% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #726      +/-   ##
==========================================
- Coverage   98.11%   98.11%   -0.01%     
==========================================
  Files         475      475              
  Lines       38119    38130      +11     
==========================================
+ Hits        37402    37412      +10     
- Misses        717      718       +1
Flag Coverage Δ
integration 98.06% <95.00%> (-0.01%) ⬇️
latest-uploader-overall 98.06% <95.00%> (-0.01%) ⬇️
unit 98.06% <95.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.06% <93.87%> (-0.01%) ⬇️
OutsideTasks 98.09% <95.00%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
services/report/languages/tests/unit/test_lcov.py 100.00% <100.00%> (ø)
services/report/languages/lcov.py 95.19% <93.87%> (-0.77%) ⬇️
Related Entrypoints
run/app.tasks.upload.UploadProcessor

@codecov-public-qa Codecov Public QA
Copy link

Codecov Report

Attention: Patch coverage is 95.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 98.06%. Comparing base (95d0b4a) to head (29b1203).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #726      +/-   ##
==========================================
- Coverage   98.07%   98.06%   -0.01%     
==========================================
  Files         434      434              
  Lines       36764    36775      +11     
==========================================
+ Hits        36055    36065      +10     
- Misses        709      710       +1
Flag Coverage Δ
integration 98.06% <95.00%> (-0.01%) ⬇️
latest-uploader-overall 98.06% <95.00%> (-0.01%) ⬇️
unit 98.06% <95.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.95% <93.87%> (-0.01%) ⬇️
OutsideTasks 98.09% <95.00%> (-0.01%) ⬇️
Files Coverage Δ
services/report/languages/tests/unit/test_lcov.py 100.00% <100.00%> (ø)
services/report/languages/lcov.py 95.00% <93.87%> (-0.79%) ⬇️

@Swatinem Swatinem added this pull request to the merge queue Sep 19, 2024
Merged via the queue into main with commit 3c67255 Sep 19, 2024
24 of 27 checks passed
@Swatinem Swatinem deleted the swatinem/lcov-errors branch September 19, 2024 14:00
@drazisil-codecov drazisil-codecov mentioned this pull request Sep 23, 2024
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@giovanni-guidini giovanni-guidini giovanni-guidini approved these changes

Assignees

@Swatinem Swatinem

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Swatinem @giovanni-guidini
0