-
Notifications
You must be signed in to change notification settings - Fork 11
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #805 +/- ##
=======================================
Coverage 97.99% 97.99%
=======================================
Files 446 446
Lines 35623 35623
=======================================
Hits 34909 34909
Misses 714 714
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #805 +/- ##
==========================================
+ Coverage 97.99% 98.00% +0.01%
==========================================
Files 446 443 -3
Lines 35623 36462 +839
==========================================
+ Hits 34909 35735 +826
- Misses 714 727 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #805 +/- ##
==========================================
+ Coverage 97.99% 98.00% +0.01%
==========================================
Files 446 443 -3
Lines 35623 36462 +839
==========================================
+ Hits 34909 35735 +826
- Misses 714 727 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@@ -20,6 +20,78 @@ | |||
|
|||
|
|||
class TestUploadTestProcessorTask(object): | |||
def test_compute_name(self): | |||
assert ( | |||
TestResultsProcessorTask().compute_name( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as a followup, it would be nice to move this method out of TestResultsProcessorTask
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh i think that second commit wasn't actually supposed to make it in to this PR, i will fix that
this PR is supposed to be just the Makefile
changes to add -o junit_family=legacy
to where we run our tests
f12b5d5
to
4000f6f
Compare
✅ All tests successful. No failed tests were found. 📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
No description provided.