8000 feat: add logging to test results processor task by joseph-sentry · Pull Request #882 · codecov/worker · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on May 5, 2025. It is now read-only.

feat: add logging to test results processor task #882

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

joseph-sentry
Copy link
Contributor

No description provided.

Copy link
sentry-io bot commented Nov 12, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: tasks/test_results_processor.py

Function Unhandled Issue
process_individual_arg JSONDecodeError: Expecting value: line 1 column 1 (char 0) app.tasks.test_results.TestResult...
Event Count: 4
process_individual_upload FileNotInStorageError: File test_results/v1/raw/2024-11-06/25D3451FB922A5B3C2F2E4A374E5B8F0/96a311895d56ba274a12a4d2cd4d... ...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

@codecov-qa
8000
Copy link
codecov-qa bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.00%. Comparing base (0d27b33) to head (e42d689).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #882   +/-   ##
=======================================
  Coverage   98.00%   98.00%           
=======================================
  Files         444      444           
  Lines       35410    35412    +2     
=======================================
+ Hits        34705    34707    +2     
  Misses        705      705           
Flag Coverage Δ
integration 41.95% <100.00%> (+<0.01%) ⬆️
unit 90.81% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.04% <100.00%> (+<0.01%) ⬆️
OutsideTasks 95.86% <ø> (ø)
Files with missing lines Coverage Δ
tasks/test_results_processor.py 95.31% <100.00%> (+0.04%) ⬆️

Copy link
codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.00%. Comparing base (0d27b33) to head (e42d689).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #882   +/-   ##
=======================================
  Coverage   98.00%   98.00%           
=======================================
  Files         444      444           
  Lines       35410    35412    +2     
=======================================
+ Hits        34705    34707    +2     
  Misses        705      705           
Flag Coverage Δ
integration 41.95% <100.00%> (+<0.01%) ⬆️
unit 90.81% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.04% <100.00%> (+<0.01%) ⬆️
OutsideTasks 95.86% <ø> (ø)
Files with missing lines Coverage Δ
tasks/test_results_processor.py 95.31% <100.00%> (+0.04%) ⬆️

@codecov-notifications
Copy link
codecov-notifications bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #882   +/-   ##
=======================================
  Coverage   98.00%   98.00%           
=======================================
  Files         444      444           
  Lines       35410    35412    +2     
=======================================
+ Hits        34705    34707    +2     
  Misses        705      705           
Flag Coverage Δ
integration 41.95% <100.00%> (+<0.01%) ⬆️
unit 90.81% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.04% <100.00%> (+<0.01%) ⬆️
OutsideTasks 95.86% <ø> (ø)
Files with missing lines Coverage Δ
tasks/test_results_processor.py 95.31% <100.00%> (+0.04%) ⬆️

Copy link
codecov-public-qa bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.00%. Comparing base (0d27b33) to head (e42d689).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #882   +/-   ##
=======================================
  Coverage   98.00%   98.00%           
=======================================
  Files         444      444           
  Lines       35410    35412    +2     
=======================================
+ Hits        34705    34707    +2     
  Misses        705      705           
Flag Coverage Δ
integration 41.95% <100.00%> (+<0.01%) ⬆️
unit 90.81% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.04% <100.00%> (+<0.01%) ⬆️
OutsideTasks 95.86% <ø> (ø)
Files with missing lines Coverage Δ
tasks/test_results_processor.py 95.31% <100.00%> (+0.04%) ⬆️

Copy link

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@joseph-sentry joseph-sentry requested review from Swatinem and a team and removed request for Swatinem November 12, 2024 16:17
@joseph-sentry joseph-sentry added this pull request to the merge queue Nov 12, 2024
Merged via the queue into main with commit c3d699a Nov 12, 2024
26 of 27 checks passed
@joseph-sentry joseph-sentry deleted the joseph/better-logging branch November 12, 2024 18:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0