8000 Do not trigger `Notify` twice from `TestResultsFinisher` by Swatinem · Pull Request #900 · codecov/worker · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on May 5, 2025. It is now read-only.

Do not trigger Notify twice from TestResultsFinisher #900

Merged
merged 2 commits into from 8000
Nov 20, 2024
Merged

Do not trigger Notify twice from TestResultsFinisher #900

merged 2 commits into from
Nov 20, 2024

Conversation

Swatinem
Copy link
Contributor

This also fixes up the return value in case the test results comment was updates.

Plus, it does a little formatting and typing cleanup.

@Swatinem
Do not trigger Notify twice from TestResultsFinisher
ff1cfc5 
This also fixes up the return value in case the test results comment was updates.

Plus, it does a little formatting and typing cleanup.
@Swatinem Swatinem self-assigned this Nov 18, 2024
joseph-sentry
joseph-sentry approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor
@joseph-sentry joseph-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@codecov Codecov
Copy link
codecov bot commented Nov 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.06%. Comparing base (c20baed) to head (bc5307f).
Report is 6 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #900      +/-   ##
==========================================
+ Coverage   98.04%   98.06%   +0.01%     
==========================================
  Files         444      444              
  Lines       35435    35471      +36     
==========================================
+ Hits        34744    34783      +39     
+ Misses        691      688       -3
Flag Coverage Δ
integration 41.93% <100.00%> (-0.03%) ⬇️
unit 90.87% <20.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.16% <100.00%> (+0.02%) ⬆️
OutsideTasks 95.95% <ø> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
tasks/test_results_finisher.py 93.52% <100.00%> (-0.08%) ⬇️
tasks/tests/unit/test_test_results_finisher.py 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

@codecov-notifications
Copy link
codecov-notifications bot commented Nov 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #900      +/-   ##
==========================================
+ Coverage   98.04%   98.06%   +0.01%     
==========================================
  Files         444      444              
  Lines       35435    35471      +36     
==========================================
+ Hits        34744    34783      +39     
+ Misses        691      688       -3
Flag Coverage Δ
integration 41.93% <100.00%> (-0.03%) ⬇️
unit 90.87% <20.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.16% <100.00%> (+0.02%) ⬆️
OutsideTasks 95.95% <ø> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
tasks/test_results_finisher.py 93.52% <100.00%> (-0.08%) ⬇️
tasks/tests/unit/test_test_results_finisher.py 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

@codecov-qa
Copy link
codecov-qa bot commented Nov 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.06%. Comparing base (c20baed) to head (bc5307f).
Report is 6 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #900      +/-   ##
==========================================
+ Coverage   98.04%   98.06%   +0.01%     
==========================================
  Files         444      444              
  Lines       35435    35471      +36     
==========================================
+ Hits        34744    34783      +39     
+ Misses        691      688       -3
Flag Coverage Δ
integration 41.93% <100.00%> (-0.03%) ⬇️
unit 90.87% <20.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.16% <100.00%> (+0.02%) ⬆️
OutsideTasks 95.95% <ø> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
tasks/test_results_finisher.py 93.52% <100.00%> (-0.08%) ⬇️
tasks/tests/unit/test_test_results_finisher.py 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

@codecov-public-qa Codecov Public QA
Copy link
codecov-public-qa bot commented Nov 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.06%. Comparing base (c20baed) to head (bc5307f).
Report is 6 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #900      +/-   ##
==========================================
+ Coverage   98.04%   98.06%   +0.01%     
==========================================
  Files         444      444              
  Lines       35435    35471      +36     
==========================================
+ Hits        34744    34783      +39     
+ Misses        691      688       -3
Flag Coverage Δ
integration 41.93% <100.00%> (-0.03%) ⬇️
unit 90.87% <20.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.16% <100.00%> (+0.02%) ⬆️
OutsideTasks 95.95% <ø> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
tasks/test_results_finisher.py 93.52% <100.00%> (-0.08%) ⬇️
tasks/tests/unit/test_test_results_finisher.py 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

@github-actions GitHub Actions
Copy link

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@Swatinem Swatinem added this pull request to the merge queue Nov 20, 2024
Merged via the queue into main with commit 9e869fa Nov 20, 2024
26 of 27 checks passed
@Swatinem Swatinem deleted the swatinem/no-notify-test-twice branch November 20, 2024 09:17
@Swatinem Swatinem mentioned this pull request Nov 26, 2024
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joseph-sentry joseph-sentry joseph-sentry approved these changes

Assignees

@Swatinem Swatinem

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Swatinem @joseph-sentry
0