8000 fix: upsert branch and pull when updating commit by joseph-sentry · Pull Request #903 · codecov/worker · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on May 5, 2025. It is now read-only.

fix: upsert branch and pull when updating commit #903

Merged
merged 1 commit into from
Nov 25, 2024
Merged

fix: upsert branch and pull when updating commit #903

merged 1 commit into from
Nov 25, 2024

Conversation

joseph-sentry
Copy link
Contributor

when we update a commit, we want to ensure the commit's corresponding pull and branch are also upserted to reflect whatever changes were made to the commit

this is duplicating the logic in the commits_insert_pr_branch and commits_update_heads db triggers

@joseph-sentry
fix: upsert branch and pull when updating commit
2dcfba2 
when we update a commit, we want to ensure the commit's corresponding
pull and branch are also upserted to reflect whatever changes were made
to the commit
@codecov Codecov
Copy link
codecov bot commented Nov 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 72.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 97.99%. Comparing base (3676a01) to head (2dcfba2).
Report is 12 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
tasks/commit_update.py 61. 8000 11% 7 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #903      +/-   ##
==========================================
- Coverage   98.01%   97.99%   -0.02%     
==========================================
  Files         444      444              
  Lines       35540    35564      +24     
==========================================
+ Hits        34835    34852      +17     
- Misses        705      712       +7
Flag Coverage Δ
integration 42.01% <72.00%> (+0.01%) ⬆️
unit 90.81% <8.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link
codecov-notifications bot commented Nov 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 72.00000% with 7 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
tasks/commit_update.py 61.11% 7 Missing ⚠️

📢 Thoughts on this report? Let us know!

@github-actions GitHub Actions
Copy link

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@joseph-sentry joseph-sentry requested a review from a team November 20, 2024 14:35
@joseph-sentry joseph-sentry added this pull request to the merge queue Nov 25, 2024
Merged via the queue into main with commit 4878f39 Nov 25, 2024
18 of 27 checks passed
@joseph-sentry joseph-sentry deleted the joseph/commit-update branch November 25, 2024 18:21
@sentry-io Sentry.io
Copy link
sentry-io bot commented Nov 25, 2024 •
edited
Loading

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ IntegrityError: ["raised as a result of Query-invoked autoflush; consider using a session.no_autoflush block if t... app.tasks.commit_update.CommitUpdate View Issue
  • ‼️ TypeError: argument of type 'NoneType' is not iterable app.tasks.commit_update.CommitUpdate View Issue
  • ‼️ TypeError: '<' not supported between instances of 'datetime.datetime' and 'str' app.tasks.commit_update.CommitUpdate View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Swatinem Swatinem Swatinem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joseph-sentry @Swatinem
0