8000 fix(arg-parsing): preserve base test artifacts directory by ncaq · Pull Request #109 · codedownio/sandwich · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(arg-parsing): preserve base test artifacts directory #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 2, 2025
Merged

fix(arg-parsing): preserve base test artifacts directory #109

merged 1 commit into from
Jul 2, 2025
+3 −1

Conversation

ncaq
Copy link
Contributor
@ncaq ncaq commented Jul 1, 2025

I want to change test artifacts directory.
And I want use arg options.

@ncaq
fix(arg-parsing): preserve base test artifacts directory
cd66553 
I want to change test artifacts directory.
And I want use arg options.
@thomasjm
Copy link
Collaborator
thomasjm commented Jul 2, 2025

Thanks! This looks fine.

This made me realize it's a little crazy how this currently works. When you use TestArtifactsNone for your artifacts dir and pass it to runSandwichWithCommandLineArgs, we always replace it with either a fixed or generated dir. There's no way to have TestArtifactsNone when you use the command line args functions.

I think maybe we should add another command line flag like --no-artifacts to enable this.

@thomasjm thomasjm merged commit f024abb into codedownio:master Jul 2, 2025
19 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ncaq @thomasjm
163A
0