feat: add ephemeral parameter dialog for workspace start/restart #18413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add EphemeralParametersDialog component to inform users about ephemeral parameters - Modify WorkspaceReadyPage to check for ephemeral parameters before start/restart - Update BuildParametersPopover to show ephemeral parameter info for non-classic flow - Update WorkspaceParametersPageExperimental button text based on template version - Only trigger for templates with use_classic_parameter_flow = false Co-authored-by: jaaydenh <1858163+jaaydenh@users.noreply.github.com>
- Fix TypeScript errors in EphemeralParametersDialog and BuildParametersPopover - Use correct Button component pattern with asChild and Link Co-authored-by: jaaydenh <1858163+jaaydenh@users.noreply.github.com>
jaaydenh
reviewed
Jun 18, 2025
| @@ -22,6 +22,8 @@ const badgeVariants = cva( | |||
| "border border-solid border-border-warning bg-surface-orange text-content-warning shadow", | |||
| destructive: | |||
| "border border-solid border-border-destructive bg-surface-red text-highlight-red shadow", | |||
| green: | |||
There was a problem hiding this comment.
This is only meant to be used for ephemeral parameters and no other use cases. It felt like calling this ephemeral is too specific for the badge component so I left it as a generic green for now.
Emyrk
reviewed
Jun 18, 2025
If the user clicks "Continue", from a frontend perspective, it should be the exact same behavior as before which means the ephemeral parameters are not given new values. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #17709
FYI, blink created a first draft which was heavily modified.
Summary
This PR implements ephemeral parameter handling for workspace start/restart operations when templates use dynamic parameters (
use_classic_parameter_flow = false).Changes
1. EphemeralParametersDialog Component
site/src/components/EphemeralParametersDialog/2. WorkspaceReadyPage Updates
checkEphemeralParameters()function usingAPI.getDynamicParametershandleStartandhandleRestartto check for ephemeral parametersuse_classic_parameter_flow = false3. BuildParametersPopover Updates
WorkspaceParametersPageExperimental