8000 chore(agent): add workspace owner env var and log dev container app failures by DanielleMaywood · Pull Request #18433 · coder/coder · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore(agent): add workspace owner env var and log dev container app failures #18433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

chore(agent): add workspace owner env var and log dev container app failures #18433

wants to merge 6 commits into from
+19 −1

Conversation

DanielleMaywood
Copy link
Contributor
@DanielleMaywood DanielleMaywood commented Jun 18, 2025 •
edited
Loading

Listen to feedback that was missed in #18346

  • Adds CODER_WORKSPACE_OWNER_NAME into the agent environment.
  • Logs warnings for when dev container app creation fails.

@DanielleMaywood DanielleMaywood marked this pull request as ready for review June 18, 2025 16:05
@DanielleMaywood DanielleMaywood requested a review from mafredri June 18, 2025 16:31
mafredri
mafredri approved these changes Jun 18, 2025
View reviewed changes
Copy link
Member
@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

Just one small request, please update the PR title to match the changes. 😄

mafredri
mafredri reviewed Jun 18, 2025
View reviewed changes
@DanielleMaywood DanielleMaywood changed the title chore(agent): feedback based on #18346 chore(agent): add workspace owner env var and log dev container app failures Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mafredri mafredri mafredri approved these changes

Assignees

@DanielleMaywood DanielleMaywood

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielleMaywood @mafredri
0