Ignore backup files of hooks #768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 100%@@ master #768 diff @@
====================================
Files 13 13
Lines 584 585 +1
Methods 0 0
Messages 0 0
Branches 0 0
====================================
+ Hits 584 585 +1
Misses 0 0
Partials 0 0
|
|
Nice! 👍 |
|
|
||
| if not filename.endswith('~') and basename in _HOOKS: | ||
| hooks[basename] = os.path.abspath(os.path.join(hooks_dir, f)) | ||
| return hooks |
There was a problem hiding this comment.
I'm not really a fan of this existing implementation- the caller knows which hook it's looking for, so it's weird that we iterate through all the hook files on pre- and post-...
|
Let's refactor |
|
🍰 Cool to merge post CI. |
michaeljoseph
added a commit
to michaeljoseph/cookiecutter
that referenced
this pull request
Jun 27, 2016
|
Thanks for the review and the merge @michaeljoseph! 🍰 |
|
You make it my pleasure @hackebrot 😻 |
terryjbates
pushed a commit
to terryjbates/cookiecutter
that referenced
this pull request
Jul 23, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #767