Friendly error messages for VCS failures #778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Single quotes per standards and doctoring cleanup
| @@ -113,3 +113,26 @@ class RepositoryNotFound(CookiecutterException): | |||
| """ | |||
| Raised when the specified cookiecutter repository doesn't exist. | |||
| """ | |||
|
|
|||
|
|
|||
| class RepositoryCloneFailed(CookiecutterException): | |||
Current coverage is 100%@@ master #778 diff @@
====================================
Files 14 14
Lines 591 600 +9
Methods 0 0
Messages 0 0
Branches 0 0
====================================
+ Hits 591 600 +9
Misses 0 0
Partials 0 0
|
| BRANCH_ERRORS = [ | ||
| 'error: pathspec', | ||
| 'unknown revision', | ||
| ] |
There was a problem hiding this comment.
Is this working for both git and mercurial?
There was a problem hiding this comment.
Yup, here are the actual error messages: https://github.com/audreyr/cookiecutter/pull/778/files/55f6f0215a5293b8dc6baafb978e85bc725ffb45#diff-8327dc289ba1c55ec5be92a9f27829ffR186
658f544 to
5351a7a
Compare
| @@ -115,9 +123,29 @@ def clone(repo_url, checkout=None, clone_to_dir=".", no_input=False): | |||
| prompt_and_delete_repo(repo_dir, no_input=no_input) | |||
|
|
|||
| if repo_type in ['git', 'hg']: | |||
There was a problem hiding this comment.
I think this is not required as we run identify_repo before that.
There was a problem hiding this comment.
Cool, will fix.
|
Great work @michaeljoseph! 👏 |
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #776