Fixed #479 - Added support for dictionary data in configurations. #815
Conversation
Current coverage is 100% (diff: 100%)@@ master #815 diff @@
====================================
Files 15 15
Lines 605 630 +25
Methods 0 0
Messages 0 0
Branches 0 0
====================================
+ Hits 605 630 +25
Misses 0 0
Partials 0 0
|
| @@ -0,0 +1,63 @@ | |||
| .. _dict-variables: | |||
|
|
|||
| Dictionary Variables (1.1+) | |||
There was a problem hiding this comment.
This feature would be part of cookiecutter v1.5.
|
Hi @freakboy3742! 👋 Thank you for submitting this PR. I had a brief glance at the changes and they look good to me. I left one comment for the docs addition. Hope I get to review this more thoroughly soon. Thanks again 🙇 |
|
@hackebrot Thanks for that - I've just updated the documentation as requested. |
|
I like this particular API change, it's very close to what I've thought would be a great way to extend the API, albeit in a way that will force people to upgrade. The code is very clean too. That said, does it make sense to possibly flag some keys for special behavior? Not in this particular pull request, but in a new one (or branch). For example, adding a dictionary that allows for better help specifications on the command-line (FWIW, this was a Guido Van Rossum request). Anyway, this PR gets my 👍 |
|
Great work @freakboy3742! Thank you 🙇 I fixed a few minor issues on the docs example with the JSON context and the jinja2 template. |
This adds the ability to specify arbitrarily deep data structures in your cookiecutter JSON file.