8000 Add Ansible section + ferrarimarco/cookiecutter-ansible-role by ferrarimarco · Pull Request #903 · cookiecutter/cookiecutter · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add Ansible section + ferrarimarco/cookiecutter-ansible-role #903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2017
Merged

Add Ansible section + ferrarimarco/cookiecutter-ansible-role #903

merged 1 commit into from
Apr 5, 2017

Conversation

ferrarimarco
Copy link
Contributor

I added a dedicated Ansible section and a cookiecutter-ansible-role template. It's a fork of the existing one with additional features (mainly a test infrastructure and various lint checks) that were rejected by upstream.

@codecov-io
Copy link
codecov-io 8000 commented Feb 17, 2017

Codecov Report

Merging #903 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #903   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          17     17           
  Lines         684    684           
=====================================
  Hits          684    684

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6530ad...b9e795d. Read the comment docs.

@michaeljoseph
Copy link
Contributor
michaeljoseph commented Apr 3, 2017

@ferrarimarco What do you think about adding the existing iknite/cookiecutter-ansible-role to the Ansible section also? I guess you'd have to rename yours to prevent ambiguity?

@michaeljoseph michaeljoseph added the waiting-for-contributor Waiting for answer from original contributor. label Apr 3, 2017
@ferrarimarco
Copy link
Contributor Author

@michaeljoseph done

Copy link
Contributor
@michaeljoseph michaeljoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a rebase now please.

README.rst Outdated
@@ -455,6 +453,13 @@ Meta-templates for generating Cookiecutter project templates.

.. _`cookiecutter-template`: https://github.com/eviweb/cookiecutter-template

Ansible
~~
* `cookiecutter-ansible-role`_: A template to create ansible roles. Forget about file creation and focus on actions.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please extend the ~ to the end of heading and add a new line to fix the formatting?

Copy link
Contributor
@michaeljoseph michaeljoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ferrarimarco
Copy link
Contributor Author

@michaeljoseph done as requested.

I am rebasing now...

@ferrarimarco
Copy link
Contributor Author

@michaeljoseph rebase completed

README.rst Outdated
@@ -314,7 +315,7 @@ Python
* `cookiecutter-quokka-module`_: A template to create a blueprint module for Quokka Flask CMS.
* `cookiecutter-kivy`_: A template for NUI applications built upon the kivy python-framework.
* `cookiedozer`_: A template for Python Kivy apps ready to be deployed to android devices with Buildozer.
* `cookiecutter-ansible-role`_: A template to create ansible roles. Forget about file creation and focus on actions.
* `cookiecutter-pypackage-minimal`_: A minimal Python package template.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also moved cookiecutter-ansible-role in the Ansible section
@ferrarimarco
Copy link
Contributor Author

@michaeljoseph fixed, sorry

@michaeljoseph michaeljoseph merged commit 041e810 into cookiecutter:master Apr 5, 2017
@michaeljoseph
Copy link
Contributor

Awesome, thanks @ferrarimarco!

@ferrarimarco ferrarimarco deleted the add-ansible-test-kitchen-cookiecutter branch April 5, 2017 08:51
michaeljoseph added a commit to michaeljoseph/cookiecutter that referenced this pull request Apr 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-for-contributor Waiting for answer from original contributor.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0