8000 Added: --replay-file cli option, for replay file distributing by Cadair · Pull Request #906 · cookiecutter/cookiecutter · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Added: --replay-file cli option, for replay file distributing #906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
May 29, 2020
Merged

Added: --replay-file cli option, for replay file distributing #906

merged 12 commits into from
May 29, 2020

Conversation

Cadair
Copy link
Contributor
@Cadair Cadair commented Mar 1, 2017

This adds an option to main.cookiecutter and the CLI to specify a json file to read the replay data from.

The motivation for this is to provide a way to run the same replay over different machines, i.e. store the replay in a git repo.

@Cadair
Copy link
Contributor Author
Cadair commented Mar 1, 2017

If people are happy with this idea I will add tests and docs etc.

@epcim
Copy link
epcim commented May 5, 2017

+1

@hackebrot
Copy link
Member

Hi @Cadair! 👋

Thank you for your contribution. I'm not sure if this approach is better than using --no-input and some custom tooling to populate extra context.

Happy to merge this with tests and docs, if others are OK with this approach.

Ping @audreyr @pydanny @michaeljoseph

@hackebrot hackebrot added the enhancement This issue/PR relates to a feature request. label 8000 May 7, 2017
@diegoholiveira
Copy link

What's the situation about this idea? Currently, I'm looking for a way to apply a template over and over again through multiple projects, so this new option to specify a replay file will be awesome to me.

There is anything that I can do to help merging this?

@Cadair
Copy link
Contributor Author
Cadair commented Aug 31, 2017

I have not had a chance to get back to the project that this was a part of. I will try and get to it soon.

If you want to speed it up, writing tests and docs for the change in this PR is what needs doing. I will happily merge PRs against my fork with any contributions.

@browniebroke
Copy link
Member

I"m also interested in getting this new option, I think it could help maintainers of templates with several options to reproduce issues. I will try to add the missing parts...

This was referenced Aug 15, 2018
Merged
Merged
@salotz
Copy link
salotz commented Mar 21, 2020

I'm very +1 for this feature, seems like a big hole in cookiecutter functionality. Any possibility of merging any time soon? What's missing?

@hackebrot

I'm not sure if this approach is better than using --no-input and some custom tooling to populate extra context.

The proposed option is very non-intuitive. This issue is by far the least-surprise approach. Cookiecutter already accepts JSON files for the defaults. Like others have said this would simplify testing immensely.

I might suggest also adding an option to generate a .cookiecutter_replay inside of generated repos rather than some user-configured location as well. But thats another story.

@cookiecutter cookiecutter deleted a comment from codecov-io May 29, 2020
@insspb insspb added feature This issue/PR relates to major feature request. and removed enhancement This issue/PR relates to a feature request. labels May 29, 2020
@insspb insspb added this to the 2.0.0 milestone May 29, 2020
@insspb insspb self-assigned this May 29, 2020
@insspb insspb mentioned this pull request May 29, 2020
Open
@insspb insspb changed the title Add the option to specify a replay file. Added: --replay-file as cli option, for replay file distributing May 29, 2020
@insspb insspb changed the title Added: --replay-file as cli option, for replay file distributing Added: --replay-file cli option, for replay file distributing May 29, 2020
@insspb
Copy link
Member
insspb commented May 29, 2020

@Cadair @browniebroke
Thank you for contribution and sorry us for long delay with answer.
This feature is merged to master branch and will be released with cookiecutter 2.0
At this time you can use it from installing from master directly.

@diegoholiveira @epcim
This feature is merged to master branch and will be released with cookiecutter 2.0
At this time you can use it from installing from master directly.

@insspb insspb merged commit d74b085 into cookiecutter:master May 29, 2020
@insspb insspb mentioned this pull request May 29, 2020
Closed
@salotz
Copy link
salotz commented May 30, 2020

Awesome thank you for this!

@Cadair Cadair deleted the replay_file branch May 30, 2020 15:30
@insspb
Copy link
Member
insspb commented May 30, 2020

@salotz You are welcome.

@browniebroke browniebroke mentioned this pull request Jan 28, 2021
Closed
@hxin hxin mentioned this pull request Mar 3, 2021
Closed
@simobasso simobasso mentioned this pull request May 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@insspb insspb insspb approved these changes

Assignees

@insspb insspb

Labels
feature This issue/PR relates to major feature request.
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
7 participants
@Cadair @epcim @hackebrot @diegoholiveira @browniebroke @salotz @insspb
0