8000 py3: remove futures, six and encoding by insspb · Pull Request #1401 · cookiecutter/cookiecutter · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

py3: remove futures, six and encoding #1401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 27, 2020
Merged

py3: remove futures, six and encoding #1401

merged 4 commits into from
May 27, 2020

Conversation

insspb
Copy link
Member
@insspb insspb commented May 26, 2020

No description provided.

@insspb insspb changed the title Remove futures, six and encoding. Making code python 3 only. Making code python 3 only: Remove futures, six and encoding. May 26, 2020
@insspb insspb added feature This issue/PR relates to major feature request. code style This issue/PR relates to the project code style modification labels May 26, 2020
@insspb insspb self-assigned this May 26, 2020
@insspb insspb added the needs-review PR Only: This PR require review from other developer label May 26, 2020
@ssbarnea ssbarnea changed the title Making code python 3 only: Remove futures, six and encoding. py3: remove futures, six and encoding May 27, 2020
@codeclimate
Copy link
codeclimate bot commented May 27, 2020
8000

Code Climate has analyzed commit 3e34a3d and detected 5 issues on this pull request.

Here's the issue category breakdown:

Category Count
Security 5

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 99.7% (0.2% change).

View more on Code Climate.

@ssbarnea
Copy link
Member

@insspb If you could split it by change-type it would be much easier to review and merge.

@insspb
Copy link
Member Author
insspb commented May 27, 2020

@ssbarnea It is already splitted. for #1401, #1402 and many tests-related PR that will be done one by one. :)

I will merge this one in minutes, as it is already approved by you ;)

@insspb insspb merged commit e8fbf92 into master May 27, 2020
@insspb insspb deleted the drop27-35 branch May 27, 2020 10:13
@insspb insspb added this to the 2.0.0 milestone May 27, 2020
@simobasso simobasso mentioned this pull request May 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssbarnea ssbarnea ssbarnea approved these changes

@hackebrot hackebrot Awaiting requested review from hackebrot

@michaeljoseph michaeljoseph Awaiting requested review from michaeljoseph

@audreyfeldroy audreyfeldroy Awaiting requested review from audreyfeldroy

@luzfcb luzfcb Awaiting requested review from luzfcb

@pydanny pydanny Awaiting requested review from pydanny

Assignees

@insspb insspb

Labels
code style This issue/PR relates to the project code style modification feature This issue/PR relates to major feature request. needs-review PR Only: This PR require review from other developer
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@insspb @ssbarnea
0