8000 docs: rewrite the conditional files / directories example description. by lyz-code · Pull Request #1437 · cookiecutter/cookiecutter · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

docs: rewrite the conditional files / directories example description. #1437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 26, 2020

Conversation

lyz-code
Copy link
Contributor

The example didn't match the description structure of the previous
example and it mentioned the pre_gen_project, when it should be
post_gen_project hook.

Copy link
Member
@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That construct after comma does not sound right to me. There are some improvements in proposed change but is not ready yet.

@lyz-code
Copy link
Contributor Author

I just mirrored the syntax of the previous approved example ¯\(°_o)/¯.

Check out the rephrased version: 530367b

The example didn't match the description structure of the previous
example and it mentioned the pre_gen_project, when it should be
post_gen_project hook.
@lyz-code lyz-code force-pushed the docs/require_conditional_example branch from 530367b to 7bf4d68 Compare September 7, 2020 14:20
@lyz-code lyz-code requested a review from ssbarnea September 7, 2020 14:43
@lyz-code
Copy link
Contributor Author
lyz-code commented Dec 14, 2020

Hi @ssbarnea, can I do anything to speed up the merging process of this contribution?

Thanks!

@insspb insspb added the documentation This issue/PR relates to or includes documentation. label Dec 26, 2020
@insspb insspb merged commit 52dd185 into cookiecutter:master Dec 26, 2020
@simobasso simobasso mentioned this pull request May 15, 2021
cagonza6 pushed a commit to cagonza6/cookiecutter that referenced this pull request Jun 16, 2021
cookiecutter#1437)

* docs: rewrite the conditional files / directories example description.

The example didn't match the description structure of the previous
example and it mentioned the pre_gen_project, when it should be
post_gen_project hook.

* docs: improve hooks example phrasing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This issue/PR relates to or includes documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0