Fix pull requests checklist reference #1537
Conversation
524a1e9 to
390fcd6
Compare
|
@glumia, thanks for this pull request! As I said in #1529 (comment), we should await the permission of @audreyfeldroy to use her gist in this project. |
There was a problem hiding this comment.
This should not be merged in the way as it exist in this PR.
- You can extend CONTRIBUTING.md. Many things from PR_CHECKLIST already there.
- Stop creating docs files in root folder of project. We should thing about removing most of them from there. No need to create more problems. for example HISTORY.md outdated and should be moved to docs for archive purposes only.
|
@glumia Thank you for contribution. Unfortunately I do not think it can be merged as it is. I described problem in review comment. |
Of course!
Hmm okay, I was also not very sure about adding another file to project's root directory. I'll try to fit the contents of |
390fcd6 to
73027f1
Compare
The link was broken since the file was removed from github gists. Its content was recovered with Internet Archive's Wayback Machine and since it significantly overlapped with what there's already in our `CONTRIBUTING.md` it was just 'merged' into it. Credits to @audreyfeldroy as original source of those ideas. The part regarding `HISTORY.md` was removed since now the history is updated using the output of Github's release drafter when we do a new release. Relates to cookiecutter#1528
73027f1 to
258a28e
Compare
modified CONTRIBUTING.md as requested and removed the file from the root of the project
|
@glumia, thanks for the update 🙏 . |
The previous link was broken since the file was removed from github
gists. Its content was recovered with Internet Archive's Wayback Machine
and adapted to our specific context (eg. references to specific
platforms were removed since we already have tests for that on our CI).
Closes #1528