8000 Code quality: utils.make_sure_path_exists refactored and type annotated by insspb · Pull Request #1722 · cookiecutter/cookiecutter · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Code quality: utils.make_sure_path_exists refactored and type annotated #1722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 9, 2022
Merged

Code quality: utils.make_sure_path_exists refactored and type annotated #1722

merged 9 commits into from
Jun 9, 2022

Conversation

insspb
Copy link
Member
@insspb insspb commented Jun 9, 2022

Related #1403

I checked usage of make_sure_path_exists function, as one of the function related to files modification. First thought was to remove it, as it is almost wrapper over basic functions. But I decided to leave it with correct exception text, but without return.

Type annotate for functions that use make_sure_path_exists for correct values passing.

@insspb insspb added the code style This issue/PR relates to the project code style modification label Jun 9, 2022
jensens
jensens previously approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor
@jensens jensens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor idea how to phrase the log better.

@insspb @jensens
Update cookiecutter/utils.py
b0a9ebb 
Co-authored-by: Jens W. Klein <jk@kleinundpartner.at>
@insspb insspb merged commit 449f877 into master Jun 9, 2022
@insspb insspb deleted the update_make_sure_path_exists_and_related_code branch June 9, 2022 09:59
@eruber eruber mentioned this pull request Feb 5, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jensens jensens jensens left review comments

Assignees
No one assigned
Labels
code style This issue/PR relates to the project code style modification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@insspb @jensens
0