8000 Standardize EOF newlines by kurtmckee · Pull Request #1876 · cookiecutter/cookiecutter · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Standardize EOF newlines #1876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 30, 2023
Merged

Standardize EOF newlines #1876

merged 3 commits into from
Jun 30, 2023

Conversation

kurtmckee
Copy link
Member

This PR introduces these changes:

  • Add a pre-commit hook to standardize EOF newlines
  • Run pre-commit run --all-files end-of-file-fixer to standardize EOF newlines
  • Resolve test failures caused by standardized EOF newlines

As can be seen in the changes, some files did not end with a newline, and other files contained more than one blank line at the end.

Merging this will allow pre-commit.ci to further enforce standards on new commits.

@kurtmckee kurtmckee requested review from jensens and ericof June 29, 2023 13:10
@kurtmckee kurtmckee self-assigned this Jun 29, 2023
@kurtmckee kurtmckee force-pushed the standardize-eof-newlines branch from 5b72c2b to d6d1d51 Compare June 30, 2023 16:43
@ericof ericof added this to the 2.2.0 milestone Jun 30, 2023
@ericof ericof added the code style This issue/PR relates to the project code style modification label Jun 30, 2023
@ericof ericof merged commit e02de10 into cookiecutter:main Jun 30, 2023
@kurtmckee kurtmckee deleted the standardize-eof-newlines branch June 30, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericof ericof ericof approved these changes

@jensens jensens Awaiting requested review from jensens

Assignees

@kurtmckee kurtmckee

Labels
code style This issue/PR relates to the project code style modification
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@kurtmckee @ericof
0