8000 Reduce I/O by kurtmckee · Pull Request #1877 · cookiecutter/cookiecutter · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Reduce I/O #1877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 30, 2023
Merged

Reduce I/O #1877

merged 2 commits into from
Jun 30, 2023
+28 −26

Conversation

kurtmckee
Copy link
Member

This PR introduces the following changes:

  • Eliminate an else clause that follows a check for binary file output.

    This reduces code indentation.

  • Only detect the original file's newlines if _new_lines isn't configured.

    This reduces file I/O.

  • Update and standardize debug logging that announces what newline will be used.

@kurtmckee kurtmckee requested review from pydanny, jensens and ericof June 29, 2023 13:37
@kurtmckee kurtmckee self-assigned this Jun 29, 2023
@jensens jensens merged commit 2125335 into cookiecutter:main Jun 30, 2023
@kurtmckee kurtmckee deleted the reduce-io branch June 30, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jensens jensens jensens approved these changes

@pydanny pydanny Awaiting requested review from pydanny

@ericof ericof Awaiting requested review from ericof

Assignees

@kurtmckee kurtmckee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kurtmckee @jensens
0