8000 Update `.gitignore` and cite where it was copied from by kurtmckee · Pull Request #1879 · cookiecutter/cookiecutter · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update .gitignore and cite where it was copied from #1879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2023
Merged

Update .gitignore and cite where it was copied from #1879

merged 1 commit into from
Jul 4, 2023

Conversation

kurtmckee
Copy link
Member

The source is clear from the various in-file comments; now it is updated and cited.

I routinely use .venv/ as my virtual environment directory, which was not included in the old version of the Python-gitignore file. Now it is included, and I don't have to mentally ignore that directory when committing changes. 🥳 🎈 📈

@kurtmckee
Update .gitignore and cite where it was copied from
61e45c2 
The source is clear from the various in-file comments;
now it is updated and cited.
@kurtmckee kurtmckee requested review from pydanny, jensens and ericof July 3, 2023 14:07
pydanny
pydanny approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member
@pydanny pydanny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kurtmckee
Copy link
Member Author

Huzzah! Would you be willing to merge in that case?

@ericof ericof added the CI/CD This issue/PR relates to the project CI/CD update or fix. label Jul 4, 2023
8E66
@ericof ericof added this to the 2.2.0 milestone Jul 4, 2023
@ericof ericof merged commit ab3cf63 into cookiecutter:main Jul 4, 2023
@kurtmckee kurtmckee deleted the update-gitignore branch July 5, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pydanny pydanny pydanny approved these changes

@ericof ericof ericof approved these changes

@jensens jensens Awaiting requested review from jensens

Assignees
No one assigned
Labels
CI/CD This issue/PR relates to the project CI/CD update or fix.
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kurtmckee @pydanny @ericof
0