Manage domain on id in single value list as unique [PREVIEW] #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not validate domain on empty fields unless they're required [PREVIEW] (upstream: 11953)
JCavallo
reviewed
Jan 25, 2023
| relations = set(records) | ||
| relations = { | ||
| r for r in records | ||
| if getattr(r, field.name) is not None} |
There was a problem hiding this comment.
Pas très fan de ça, c'est quand même un changement de comportement (il n'est pas choquant qu'un domaine > 0 implique le fait que la valeur soit non nulle...
Et le getattr à ce moment, ça va encore abimer les perfs, non ?
There was a problem hiding this comment.
L'idée c'est que si tu veux que ton champs soit non NULL alors tu le mets requis. Mais si tu lui permets d'être NULL (et qu'il l'est) alors sa valeur étant indéterminée on ne peut pas vraiment valider le domaine.
Au niveau des perfs, ça aura fatalement un impact mais comme pour les champs relations pour lesquels le même pattern est utilisé. Ça devrait être minime.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not validate domain on empty fields unless they're required [PREVIEW]
(upstream: 11953)