Allow to save fused point cloud in colmap format when using command line #799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adjusted src/base/reconstruction.cc to import point cloud from std::vector<PlyPoints> * Adjusted src/exe/colmap.cc to allow saving in colmap format when calling stereo_fusion from command line
ahojnnes
reviewed
Jul 2, 2020
src/base/reconstruction.cc
Outdated
| @@ -864,6 +864,16 @@ void Reconstruction::ImportPLY(const std::string& path) { | |||
| } | |||
| } | |||
|
|
|||
| void Reconstruction::ImportPLY(const std::vector<PlyPoint> &plyPoints) | |||
There was a problem hiding this comment.
const std::vector<PlyPoint>& ply_points
ahojnnes
requested changes
Jul 2, 2020
src/base/reconstruction.cc
Outdated
| { | ||
| points3D_.clear(); | ||
| points3D_.reserve(plyPoints.size()); | ||
| for (const auto& plyPoint : plyPoints) { |
src/base/reconstruction.h
Outdated
| @@ -266,6 +266,7 @@ class Reconstruction { | |||
| // Import from other data formats. Note that these import functions are | |||
| // only intended for visualization of data and usable for reconstruction. | |||
| void ImportPLY(const std::string& path); | |||
| void ImportPLY(const std::vector<PlyPoint>& plyPoints); | |||
src/exe/colmap.cc
Outdated
| Reconstruction reconstruction; | ||
|
|
||
| // read data from sparse reconstruction | ||
| if (workspace_format == "colmap" ) |
There was a problem hiding this comment.
Remove space and wrap if body in {}
src/exe/colmap.cc
Outdated
| } else if (output_type == "txt") { | ||
| reconstruction.WriteText(output_path); | ||
| } else if (output_type == "ply") { | ||
| std::cout << "Writing output: " << output_path << std::endl; |
There was a problem hiding this comment.
Extract this to before the if
There was a problem hiding this comment.
I didn't which line you meant. I moved the 'std::cout ...' before the if.
ahojnnes
requested changes
Jul 27, 2020
src/exe/colmap.cc
Outdated
| @@ -266,6 +266,7 @@ int RunStereoFuser(int argc, char** argv) { | |||
| std::string workspace_format = "COLMAP"; | |||
| std::string pmvs_option_name = "option-all"; | |||
| std::string output_path; | |||
| std::string output_type; | |||
There was a problem hiding this comment.
Can we make the previous "ply" the default output type? This also requires to change to AddDefaultOption below. Thanks.
lucasthahn
pushed a commit
to tne-ai/colmap
that referenced
this pull request
Aug 17, 2022
…ine (colmap#799) * Allow to save fused point cloud in colmap format when using command line * Adjusted src/base/reconstruction.cc to import point cloud from std::vector<PlyPoints> * Adjusted src/exe/colmap.cc to allow saving in colmap format when calling stereo_fusion from command line * PR 799: Incorporated reviews * changed ply to default output type when fusing point clouds via command line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Issue #738