8000 fix camera model query by Pascal-So · Pull Request #997 · colmap/colmap · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix camera model query #997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2020
Merged

fix camera model query #997

merged 1 commit into from
Oct 11, 2020

Conversation

Pascal-So
Copy link
Contributor

The return value of StringReplace was not being used and therefore the query was done with the name still containing spaces and dashes.

@ahojnnes ahojnnes merged commit ff9a463 into colmap:dev Oct 11, 2020
@ahojnnes
Copy link
Contributor

Thanks for the fix.

lucasthahn pushed a commit to tne-ai/colmap that referenced this pull request Aug 17, 2022
@Pascal-So @lucasthahn
fix camera model query (colmap#997)
801f8a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pascal-So @ahojnnes
0