include colmap_cuda in COLMAP_LIBRARIES when compiled with cuda #1084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes colmap#1065 As discussed there, the example given in https://colmap.github.io/install.html#library does not work if colmap was compiled with cuda support because it doesnt link against the cuda_colmap library, even if the cuda functions are not used. This PR tries tries to fix the problem by adding colmap_cuda to the COLMAP_LIBRARIES variable so that the end user does not have to worry about it.
|
Thanks! |
lucasthahn
pushed a commit
to tne-ai/colmap
that referenced
this pull request
Aug 17, 2022
…ap#1084) fixes colmap#1065 As discussed there, the example given in https://colmap.github.io/install.html#library does not work if colmap was compiled with cuda support because it doesnt link against the cuda_colmap library, even if the cuda functions are not used. This PR tries tries to fix the problem by adding colmap_cuda to the COLMAP_LIBRARIES variable so that the end user does not have to worry about it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1065
As discussed there, the example given in https://colmap.github.io/install.html#library does not work if colmap was compiled with cuda support because it doesnt link against the cuda_colmap library, even if the cuda functions are not used.
This PR tries tries to fix the problem by adding colmap_cuda to the COLMAP_LIBRARIES variable so that the end user does not have to worry about it.