8000 Fix runtime crash when sparsesuite is missing from ceres by anmatako · Pull Request #1115 · colmap/colmap · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix runtime crash when sparsesuite is missing from ceres #1115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 12, 2021
Merged

Fix runtime crash when sparsesuite is missing from ceres #1115

merged 1 commit into from
Feb 12, 2021

Conversation

anmatako
Copy link
Contributor

The Ceres built-in variable sparse_linear_algebra_library_type is set correctly during build, so checking the existence of sparse support before using the SPARSE_SCHUR method avoids a runtime crash in bundle adjustment

@ahojnnes
Copy link
Contributor

LGTM, thank you!

@ahojnnes ahojnnes merged commit 2f0a442 into colmap:dev Feb 12, 2021
@anmatako anmatako deleted the dev branch February 23, 2021 04:26
lucasthahn pushed a commit to tne-ai/colmap that referenced this pull request Aug 17, 2022
@anmatako @lucasthahn
Fix runtime crash when sparsesuite is missing from ceres (colmap#1115)
0ab08e5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anmatako @ahojnnes
0