Fixed the collection of arguments in colmap.bat #1121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous use of the shift-operator lead to splitting ""-encapsulated comma-separated values (e.g. "1,2,3") into individual arguments. Therefore, parameters like --ImageReader.camera_params could not be used on Windows.
|
Thanks, took a long time for me to look at this PR (sorry!). LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous use of the shift-operator in colmap.bat lead to splitting ""-encapsulated comma-separated values (e.g. "1,2,3") into individual arguments. Therefore, parameters like --ImageReader.camera_params could not be used on Windows (see screenshot).
This pull request replaces the previous mechanism that uses the shift-operator by simply using the %* operator. This way, using --ImageReader.camera_params on Windows works flawlessly.