8000 Add new functionality in image_undistorter by anmatako · Pull Request #1168 · colmap/colmap · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add new functionality in image_undistorter #1168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 10, 2021
Merged

Add new functionality in image_undistorter #1168

merged 9 commits into from
Mar 10, 2021

Conversation

anmatako
Copy link
Contributor
@anmatako anmatako commented Mar 9, 2021

Extending the functionality of image_undistorter to support the following:

  1. We can now set the number of related images in the MVS workspace for patch-match through the new num_related_images option instead of always using the default of 20.
  2. We can optionally provide a text files with the image names we want included in the MVS problem through the new input_images option instead of always using all the registered images from the sparse model.
  3. We can avoid undistortion and replace it with a simple copy or linking of images when the images are already undistorted and we are not resizing them. The choice of copy or linking is controlled by the new copy_policy option.
  4. The undistorter now checks the status of each image undistortion task and only writes out the setup for the images that were successfully undistorted.

@ahojnnes ahojnnes self-requested a review March 9, 2021 22:27
ahojnnes
ahojnnes reviewed Mar 9, 2021
View reviewed changes
@ahojnnes ahojnnes enabled auto-merge (squash) March 10, 2021 22:10
@ahojnnes ahojnnes merged commit e92320a into colmap:dev Mar 10, 2021
@anmatako anmatako deleted the public/undistortion branch March 10, 2021 23:01
lucasthahn pushed a commit to tne-ai/colmap that referenced this pull request Aug 17, 2022
@anmatako @ahojnnes @lucasthahn
Add new functionality in image_undistorter (colmap#1168)
0ffbc66 
* Add new functionality in image_undistorter

* Address PR comments

* Update undistortion.h

Co-authored-by: Antonios Matakos <anmatako@dss.microsoft.us>
Co-authored-by: Johannes Schönberger <jsch@demuc.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahojnnes ahojnnes ahojnnes left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anmatako @ahojnnes
0