8000 Improvements to NVM, Cam, Recon3D, and Bundler exporters by drkoller · Pull Request #1187 · colmap/colmap · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Improvements to NVM, Cam, Recon3D, and Bundler exporters #1187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 27, 2021
Merged

Improvements to NVM, Cam, Recon3D, and Bundler exporters #1187

merged 3 commits into from
Mar 27, 2021

Conversation

drkoller
Copy link
Contributor

This PR improves the code for some of the model_converter export formats:

  1. Fix bugs introduced in PR Support more formats in model_converter #1147 affecting the export of Cam and Recon3D formats
  2. Add support for non-square pixels to the Cam format exporter
  3. Consistently support pinhole camera models for NVM, Cam, Recon3D, and Bundler exporters

@drkoller drkoller requested a review from ahojnnes March 25, 2021 17:00
@ahojnnes ahojnnes enabled auto-merge (squash) March 27, 2021 15:31
@ahojnnes ahojnnes merged commit 5ef013f into colmap:dev Mar 27, 2021
lucasthahn pushed a commit to tne-ai/colmap that referenced this pull request Aug 17, 2022
* Fixes to NVM/Cam/Recon3D/Bundler exporters

* Adhere to code style guide for conditional braces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0