8000 Added descriptor normalization argument to feature_extractor. by mihaidusmanu · Pull Request #1332 · colmap/colmap · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Added descriptor normalization argument to feature_extractor. #1332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2021
Merged

Added descriptor normalization argument to feature_extractor. #1332

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/exe/feature.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,12 +137,15 @@ void UpdateImageReaderOptionsFromCameraMode(ImageReaderOptions& options,
int RunFeatureExtractor(int argc, char** argv) {
std::string image_list_path;
int camera_mode = -1;
std::string descriptor_normalization = "l1_root";

OptionManager options;
options.AddDatabaseOptions();
options.AddImageOptions();
options.AddDefaultOption("camera_mode", &camera_mode);
options.AddDefaultOption("image_list_path", &image_list_path);
options.AddDefaultOption("descriptor_normalization", &descriptor_normalization,
"{'l1_root', 'l2'}");
options.AddExtractionOptions();
options.Parse(argc, argv);

Expand All @@ -155,6 +158,19 @@ int RunFeatureExtractor(int argc, char** argv) {
(CameraMode)camera_mode);
}

StringToLower(&descriptor_normalization);
if (descriptor_normalization == "l1_root") {
options.sift_extraction->normalization =
SiftExtractionOptions::Normalization::L1_ROOT;
} else if (descriptor_normalization == "l2") {
options.sift_extraction->normalization =
SiftExtractionOptions::Normalization::L2;
} else {
std::cerr << "ERROR: Invalid `descriptor_normalization`"
<< std::endl;
return EXIT_FAILURE;
}

if (!image_list_path.empty()) {
reader_options.image_list = ReadTextFileLines(image_list_path);
if (reader_options.image_list.empty()) {
Expand Down
0