Expose exe internals #1366
Merged
Expose exe internals #1366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am fine with the proposed changes. Thanks! |
This was referenced Jan 4, 2022
lucasthahn
pushed a commit
to tne-ai/colmap
that referenced
this pull request
Aug 17, 2022
* Expose CameraMode and UpdateImageReaderOptionsFromCameraMode * Expose the internals of RunPointTriangulator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In pycolmap we now bind some of the exe functions like RunPointTriangulator. See pycolmap/pipeline.cc. We therefore need COLMAP to expose some exe code that is currently hidden in anonymous namespace or argc-argv functions. Most of this code is likely useful for others and worthy to be publicly exposed, but src/exe is probably not the right place for it.
Any advice on where these bits should be moved?
@ahojnnes @mihaidusmanu @Phil26AT