8000 User/joschonb/asan cleanup by ahojnnes · Pull Request #1391 · colmap/colmap · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

User/joschonb/asan cleanup #1391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 22, 2022
Merged

User/joschonb/asan cleanup #1391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
752d393
Add Address Sanitizer options and fix reported issues
ahojnnes Jan 22, 2022
22a30e0
Add CI build
ahojnnes Jan 22, 2022
24d523f
Fix
ahojnnes Jan 22, 2022
efb3a48
Asan with clang
ahojnnes Jan 22, 2022
80949d0
Small cosmetic fixes to recent ASan support
ahojnnes Jan 22, 2022
058ac58
Merge branch 'dev' into user/joschonb/asan-cleanup
ahojnnes Jan 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .azure-pipelines/build-ubuntu.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ parameters:
asanEnabled: false

jobs:
- job: ubuntu_build_${{ replace(parameters.ubuntuVersion, '.', '') }}_cuda_${{ parameters.cudaEnabled }}_asa_${{ parameters.asanEnabled }}
- job: ubuntu_build_${{ replace(parameters.ubuntuVersion, '.', '') }}_cuda_${{ parameters.cudaEnabled }}_asan_${{ parameters.asanEnabled }}
displayName: '${{ parameters.displayName }}'
pool:
vmImage: 'ubuntu-${{ parameters.ubuntuVersion }}'
Expand Down Expand Up @@ -47,7 +47,7 @@ jobs:
sudo apt-get install -y clang-10
echo '##vso[task.setvariable variable=CC]/usr/bin/clang'
echo '##vso[task.setvariable variable=CXX]/usr/bin/clang++'
displayName: 'Install CUDA'
displayName: 'Install Clang'

- script: |
cmake --version
Expand Down
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ else()
endif()

if(ASAN_ENABLED)
message(STATUS "Enabling ASan flags")
message(STATUS "Enabling ASan support")
if(IS_CLANG OR IS_GNU)
add_compile_options(-fsanitize=address -fno-omit-frame-pointer -fsanitize-address-use-after-scope)
add_link_options(-fsanitize=address)
Expand Down
0