8000 lib folder becomes thirdparty folder by ahojnnes · Pull Request #2068 · colmap/colmap · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

lib folder becomes thirdparty folder #2068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 28, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10000
2 changes: 1 addition & 1 deletion .clang-format
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ IncludeBlocks: Regroup
IncludeCategories:
- Regex: '^"colmap'
Priority: 1
- Regex: '^"lib'
- Regex: '^"thirdparty'
Priority: 2
- Regex: '^<[[:alnum:]_]+>'
Priority: 3
Expand Down
25 changes: 12 additions & 13 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -184,19 +184,13 @@ include(GenerateVersionDefinitions)
include_directories(src)
link_directories(${COLMAP_LINK_DIRS})

add_subdirectory(src/lib)
add_subdirectory(src/colmap)

add_subdirectory(src/thirdparty)

################################################################################
# Generate source groups for Visual Studio, XCode, etc.
################################################################################

COLMAP_ADD_SOURCE_DIR(src/lib/LSD LIB_LSD_SRCS *.h *.c)
COLMAP_ADD_SOURCE_DIR(src/lib/PoissonRecon LIB_POISSON_RECON_SRCS *.h *.cpp *.inl)
COLMAP_ADD_SOURCE_DIR(src/lib/SiftGPU LIB_SIFT_GPU_SRCS *.h *.cpp *.cu)
COLMAP_ADD_SOURCE_DIR(src/lib/VLFeat LIB_VLFEAT_SRCS *.h *.c *.tc)

COLMAP_ADD_SOURCE_DIR(src/colmap/controllers CONTROLLERS_SRCS *.h *.cc)
COLMAP_ADD_SOURCE_DIR(src/colmap/estimators ESTIMATORS_SRCS *.h *.cc)
COLMAP_ADD_SOURCE_DIR(src/colmap/exe EXE_SRCS *.h *.cc)
Expand All @@ -214,15 +208,16 @@ COLMAP_ADD_SOURCE_DIR(src/colmap/tools TOOLS_SRCS *.h *.cc)
COLMAP_ADD_SOURCE_DIR(src/colmap/ui UI_SRCS *.h *.cc)
COLMAP_ADD_SOURCE_DIR(src/colmap/util UTIL_SRCS *.h *.cc)

COLMAP_ADD_SOURCE_DIR(src/thirdparty/LSD THIRDPARTY_LSD_SRCS *.h *.c)
COLMAP_ADD_SOURCE_DIR(src/thirdparty/PoissonRecon THIRDPARTY_POISSON_RECON_SRCS *.h *.cpp *.inl)
COLMAP_ADD_SOURCE_DIR(src/thirdparty/SiftGPU THIRDPARTY_SIFT_GPU_SRCS *.h *.cpp *.cu)
COLMAP_ADD_SOURCE_DIR(src/thirdparty/VLFeat THIRDPARTY_VLFEAT_SRCS *.h *.c *.tc)

# Add all of the source files to a regular library target, as using a custom
# target does not allow us to set its C++ include directories (and thus
# intellisense can't find any of the included files).
add_library(
${COLMAP_SRC_ROOT_FOLDER}
${LIB_LSD_SRCS}
${LIB_POISSON_RECON_SRCS}
${LIB_SIFT_GPU_SRCS}
${LIB_VLFEAT_SRCS}
${CONTROLLERS_SRCS}
${ESTIMATORS_SRCS}
${EXE_SRCS}
Expand All @@ -239,6 +234,10 @@ add_library(
${TOOLS_SRCS}
${UI_SRCS}
${UTIL_SRCS}
${THIRDPARTY_LSD_SRCS}
${THIRDPARTY_POISSON_RECON_SRCS}
${THIRDPARTY_SIFT_GPU_SRCS}
${THIRDPARTY_VLFEAT_SRCS}
)

# Prevent the library from being compiled automatically.
Expand Down Expand Up @@ -311,7 +310,7 @@ target_include_directories(
install(
TARGETS colmap ${COLMAP_EXPORT_LIBS}
EXPORT colmap-targets
LIBRARY DESTINATION lib/)
LIBRARY DESTINATION thirdparty/)

# Generate config and version.
include(CMakePackageConfigHelpers)
Expand Down Expand Up @@ -340,7 +339,7 @@ install(
DESTINATION include
FILES_MATCHING PATTERN "*.h")
install(
DIRECTORY src/lib
DIRECTORY src/thirdparty
DESTINATION include/colmap
FILES_MATCHING REGEX ".*[.]h|.*[.]hpp|.*[.]inl")

Expand Down
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -91,9 +91,9 @@ License
-------

The COLMAP library is licensed under the new BSD license. Note that this text
refers only to the license for COLMAP itself, independent of its dependencies,
which are separately licensed. Building COLMAP with these dependencies may
affect the resulting COLMAP license.
refers only to the license for COLMAP itself, independent of its thirdparty
dependencies, which are separately licensed. Building COLMAP with these
dependencies may affect the resulting COLMAP license.

Copyright (c) 2023, ETH Zurich and UNC Chapel Hill.
All rights reserved.
Expand Down
6 changes: 3 additions & 3 deletions doc/license.rst
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ License
=======

The COLMAP library is licensed under the new BSD license. Note that this text
refers only to the license for COLMAP itself, independent of its dependencies,
which are separately licensed. Building COLMAP with these dependencies may
affect the resulting COLMAP license.
refers only to the license for COLMAP itself, independent of its thirdparty
dependencies, which are separately licensed. Building COLMAP with these
dependencies may affect the resulting COLMAP license.

.. code-block:: text

Expand Down
2 changes: 1 addition & 1 deletion src/colmap/controllers/feature_extraction.cc
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
#include "colmap/util/cuda.h"
#include "colmap/util/misc.h"

#include "lib/SiftGPU/SiftGPU.h"
#include "thirdparty/SiftGPU/SiftGPU.h"

#include <numeric>

Expand Down
2 changes: 1 addition & 1 deletion src/colmap/controllers/feature_matching.cc
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
#include "colmap/util/cuda.h"
#include "colmap/util/misc.h"

#include "lib/SiftGPU/SiftGPU.h"
#include "thirdparty/SiftGPU/SiftGPU.h"

#include <fstream>
#include <numeric>
Expand Down
4 changes: 2 additions & 2 deletions src/colmap/estimators/bundle_adjustment.cc
Original file line number Diff line number Diff line change
Expand Up @@ -31,15 +31,15 @@

#include "colmap/estimators/bundle_adjustment.h"

#include <iomanip>

#include "colmap/estimators/cost_functions.h"
#include "colmap/scene/projection.h"
#include "colmap/sensor/models.h"
#include "colmap/util/misc.h"
#include "colmap/util/threading.h"
#include "colmap/util/timer.h"

#include <iomanip>

namespace colmap {

////////////////////////////////////////////////////////////////////////////////
Expand Down
6 changes: 3 additions & 3 deletions src/colmap/feature/sift.cc
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,9 @@
#include "colmap/util/misc.h"
#include "colmap/util/opengl_utils.h"

#include "lib/SiftGPU/SiftGPU.h"
#include "lib/VLFeat/covdet.h"
#include "lib/VLFeat/sift.h"
#include "thirdparty/SiftGPU/SiftGPU.h"
#include "thirdparty/VLFeat/covdet.h"
#include "thirdparty/VLFeat/sift.h"

#include <array>
#include <fstream>
Expand Down
2 changes: 1 addition & 1 deletion src/colmap/feature/sift_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
#include "colmap/math/random.h"
#include "colmap/util/opengl_utils.h"

#include "lib/SiftGPU/SiftGPU.h"
#include "thirdparty/SiftGPU/SiftGPU.h"

namespace colmap {

Expand Down
2 changes: 1 addition & 1 deletion src/colmap/image/line.cc
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
#include "colmap/util/logging.h"

extern "C" {
#include "lib/LSD/lsd.h"
#include "thirdparty/LSD/lsd.h"
}

namespace colmap {
Expand Down
2 changes: 1 addition & 1 deletion src/colmap/image/warp.cc
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@

#include "colmap/util/logging.h"

#include "lib/VLFeat/imopv.h"
#include "thirdparty/VLFeat/imopv.h"

#include <Eigen/Geometry>

Expand Down
4 changes: 2 additions & 2 deletions src/colmap/mvs/meshing.cc
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@
#include "colmap/util/threading.h"
#include "colmap/util/timer.h"

#include "lib/PoissonRecon/PoissonRecon.h"
#include "lib/PoissonRecon/SurfaceTrimmer.h"
#include "thirdparty/PoissonRecon/PoissonRecon.h"
#include "thirdparty/PoissonRecon/SurfaceTrimmer.h"

#if defined(COLMAP_CGAL_ENABLED)

Expand Down
2 changes: 1 addition & 1 deletion src/colmap/sensor/bitmap.cc
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
#include "colmap/util/logging.h"
#include "colmap/util/misc.h"

#include "lib/VLFeat/imopv.h"
#include "thirdparty/VLFeat/imopv.h"

#include <regex>
#include <unordered_map>
Expand Down
4 changes: 2 additions & 2 deletions src/colmap/ui/render_options.h
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@

#pragma once

#include <iostream>

#include "colmap/util/logging.h"

#include <iostream>

namespace colmap {

struct RenderOptions {
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
0