8000 Add missing "include <memory>" needed for unique_ptr by Tobias-Fischer · Pull Request #2338 · colmap/colmap · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add missing "include <memory>" needed for unique_ptr #2338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 9, 2024
Merged

Add missing "include <memory>" needed for unique_ptr #2338

merged 4 commits into from
Jan 9, 2024

Conversation

Tobias-Fischer
Copy link
Contributor
@Tobias-Fischer Tobias-Fischer commented Jan 8, 2024 •
edited
Loading

Fix:

/home/conda/feedstock_root/build_artifacts/colmap_1704738145804/work/src/colmap/image/line.cc: In function 'std::vector<colmap::LineSegment> colmap::DetectLineSegments(const colmap::Bitmap&, double)': /home/conda/feedstock_root/build_artifacts/colmap_1704738145804/work/src/colmap/image/line.cc:63:8: error: 'unique_ptr' is not a member of 'std'
   63 |   std::unique_ptr<double, RawDeleter> segments_data(
      |        ^~~~~~~~~~
/home/conda/feedstock_root/build_artifacts/colmap_1704738145804/work/src/colmap/image/line.cc:36:1: note: 'std::unique_ptr' is defined in header '<memory>'; did you forget to '#include <memory>'?

@Tobias-Fischer
Add missing "include <memory>" needed for unique_ptr
e30c289 
Fix:
/home/conda/feedstock_root/build_artifacts/colmap_1704738145804/work/src/colmap/image/line.cc: In function 'std::vector<colmap::LineSegment> colmap::DetectLineSegments(const colmap::Bitmap&, double)':
/home/conda/feedstock_root/build_artifacts/colmap_1704738145804/work/src/colmap/image/line.cc:63:8: error: 'unique_ptr' is not a member of 'std'
   63 |   std::unique_ptr<double, RawDeleter> segments_data(
      |        ^~~~~~~~~~
/home/conda/feedstock_root/build_artifacts/colmap_1704738145804/work/src/colmap/image/line.cc:36:1: note: 'std::unique_ptr' is defined in header '<memory>'; did you forget to '#include <memory>'?
@Tobias-Fischer
Another missing include
d221ae8
@timsutton timsutton mentioned this pull request Jan 8, 2024
Merged
@ahojnnes
Copy link
Contributor
ahojnnes commented Jan 8, 2024

Thanks, this will need a clang-format run using scripts/format/clang_format.sh. Thanks.

@Tobias-Fischer
Copy link
Contributor Author

Hi @ahojnnes - are you ok to run the clang-format, please?

Thanks.

@timsutton
Copy link
timsutton commented Jan 9, 2024 •
edited
Loading

@Tobias-Fischer You can (locally) run scripts/format/clang_format.sh in this branch and push to this PR.

@ahojnnes
Copy link
Contributor
ahojnnes commented Jan 9, 2024

@Tobias-Fischer I cannot actually modify a branch in your fork. I modified the files in-situ directly here in the PR.

@ahojnnes ahojnnes enabled auto-merge (squash) January 9, 2024 17:04
@ahojnnes ahojnnes merged commit 71cebde into colmap:main Jan 9, 2024
@Tobias-Fischer Tobias-Fischer deleted the patch-17 branch January 9, 2024 19:10
@sarlinpe sarlinpe mentioned this pull request Jan 10, 2024
Closed
@chenrui333 chenrui333 mentioned this pull request Jul 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tobias-Fischer @ahojnnes @timsutton
0