Split Dockerfile in two stages: builder and runtime. #2347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, great improvement. |
pablospe
commented
Jan 12, 2024
pablospe
commented
Jan 12, 2024
|
FYI, this PR reduces the docker image ~3GB :) (image from https://hub.docker.com/r/colmap/colmap) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting the Dockerfile in two stages reduces the size of the final image considerably, since all the build dependencies are not needed.
You can still create the tag for the stages separately:
But the default command (without
--target) is the last stage, so:docker build -t colmap:latest .will refer to
--target runtimebecause it is the last stage in the Dockerfile.