8000 Define vcpkg manifest by ahojnnes · Pull Request #2426 · colmap/colmap · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Define vcpkg manifest #2426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
Feb 21, 2024
Merged

Define vcpkg manifest #2426

merged 29 commits into from
Feb 21, 2024

Conversation

ahojnnes
Copy link
Contributor

No description provided.

sarlinpe
sarlinpe reviewed Feb 18, 2024
View reviewed changes
sarlinpe
sarlinpe reviewed Feb 18, 2024
View reviewed changes
@ahojnnes ahojnnes marked this pull request as ready for review February 19, 2024 08:20
@sarlinpe
Copy link
Member

In manifest mode, dependencies are installed in colmap/build/vcpkg_installed/$TRIPLET/ instead of vcpkg/installed/$TRIPLET/. When building an external library that depends on colmap (pycolmap here), how to tell vcpkg to search for dependencies at the new location?

@ahojnnes ahojnnes enabled auto-merge (squash) February 21, 2024 20:58
@ahojnnes ahojnnes merged commit 7a1da99 into main Feb 21, 2024
@ahojnnes ahojnnes deleted the user/joschonb/vcpkg-manifest branch February 21, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarlinpe sarlinpe sarlinpe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahojnnes @sarlinpe
0