8000 Do triangulation in the IncrementalMapperController by sarlinpe · Pull Request #2429 · colmap/colmap · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Do triangulation in the IncrementalMapperController #2429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 21, 2024
Merged

Do triangulation in the IncrementalMapperController #2429

merged 3 commits into from
Feb 21, 2024

Conversation

sarlinpe
Copy link
Member

This shouldn't incur any logic change.

@sarlinpe sarlinpe changed the title Perfrom triangulation in the IncrementalMapperController Do triangulation in the IncrementalMapperController Feb 19, 2024
@sarlinpe sarlinpe marked this pull request as ready for review February 19, 2024 09:58
@sarlinpe sarlinpe requested a review from ahojnnes February 19, 2024 09:58
@sarlinpe sarlinpe mentioned this pull request Feb 20, 2024
Open
ahojnnes
ahojnnes reviewed Feb 20, 2024
View reviewed changes
src/colmap/sfm/incremental_mapper.cc
@@ -798,7 +796,6 @@ void IncrementalMapper::IterativeGlobalRefinement(
break;
}
}
FilterImages(options);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We now lost the ability to remove degenerate images here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved it to the parent scope so it doesn't get called when triangulating only

colmap/src/colmap/controllers/incremental_mapper.cc

Line 47 in 1ff3857

mapper.FilterImages(mapper_options);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thx

@ahojnnes ahojnnes merged commit 7730f30 into colmap:main Feb 21, 2024
@Ahmed-Salama
Copy link
Contributor

I noticed that the old implementation calls mapper.CompleteAndMergeTracks(tri_options); however the new refactored code miss that part. Was that intentional or is that a mistake?

@sarlinpe
Copy link
Member Author

@Ahmed-Salama CompleteAndMergeTracks should be called in IncrementalMapper::IterativeLocalRefinement, which is called in the new IncrementalMapperController::TriangulateReconstruction function. Did you observe that this does not occur in practice?

@sarlinpe sarlinpe deleted the sarlinpe/tri-in-controller branch May 13, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahojnnes ahojnnes ahojnnes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sarlinpe @Ahmed-Salama @ahojnnes
0