Split pair generation and matching #2573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahojnnes
reviewed
May 22, 2024
ahojnnes
reviewed
May 22, 2024
ahojnnes
reviewed
May 22, 2024
| } | ||
|
|
||
| class ExhaustiveFeatureMatcher : public Thread { | ||
| template <typename DerivedPairGenerator> |
There was a problem hiding this comment.
I guess instead of templating we could pass an abstract pair generator and the cache object from the outside. Not necessarily important for here but theoretically has some benefits for injecting a mock/fake for testing purposes of this class.
ahojnnes
reviewed
May 22, 2024
ahojnnes
reviewed
May 22, 2024
ahojnnes
approved these changes
May 22, 2024
ahojnnes
approved these changes
May 24, 2024
|
@sarlinpe Mac is unhappy with the following error: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt at splitting the generation of image pairs (exhaustive, spatial, vocabulary tree, sequential) and the matching process, which were deeply entangled. This simplifies the code and makes it possible to generate the pairs from Python for a subsequent Python-based matching.
The design is sometimes convoluted because I make sure to avoid materializing all pairs in memory, and instead generate them by batches.
This currently lives in
controllers/but could be moved tofeatures/.