8000 Remove CamFromWorldPrior and create LocationPrior by sarlinpe · Pull Request #2620 · colmap/colmap · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove CamFromWorldPrior and create LocationPrior #2620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Jul 3, 2024
Merged

Remove CamFromWorldPrior and create LocationPrior #2620

merged 16 commits into from
Jul 3, 2024

Conversation

sarlinpe
Copy link
Member
@sarlinpe sarlinpe commented Jun 28, 2024 •
edited
Loading
  • Create a new LocationPrior object that replaces Image::CamFromWorldPrior
    • For now it does not store any rotation, since this is not used anywhere in the code
    • It stores a coordinate system so we can distinguish between WGS84, a Cartesian system like ECEF/ENU/LV95, or any datum that we might want to support in the future
    • It can later be extended to store an accuracy estimate, a timestamp (if different from the corresponding image), etc.
  • Since the pose prior is rarely used (only for model alignment or spatial matching), it should not break anyone's workflow - we provide a migration script if this does.

@sarlinpe sarlinpe requested review from ahojnnes and B1ueber2y June 30, 2024 09:32
ahojnnes
ahojnnes reviewed Jul 1, 2024
View reviewed changes
ahojnnes
ahojnnes reviewed Jul 1, 2024
View reviewed changes
@sarlinpe sarlinpe requested a review from ahojnnes July 3, 2024 07:50
@sarlinpe sarlinpe merged commit c5c7b9c into main Jul 3, 2024
15 checks passed
@sarlinpe sarlinpe deleted the sarlinpe/location-prior branch July 3, 2024 13:00
@sephyli
Copy link
sephyli commented Aug 5, 2024

@sarlinpe Should we also remove the code here?

@sarlinpe sarlinpe mentioned this pull request Aug 13, 2024
Merged
@sarlinpe
Copy link
Member Author

@sephyli Good catch, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahojnnes ahojnnes ahojnnes approved these changes

@B1ueber2y B1ueber2y Awaiting requested review from B1ueber2y

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sarlinpe @sephyli @ahojnnes
0