8000 Add fix for specifying the correct pycolmap CMake python development … by fulkast · Pull Request #2683 · colmap/colmap · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add fix for specifying the correct pycolmap CMake python development … #2683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Add fix for specifying the correct pycolmap CMake python development … #2683

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95051b1
Add fix for specifying the correct pycolmap CMake python development …
fulkast Jul 31, 2024
7a20950
Merge branch 'main' into fix/pycolmap-python-module-name
ahojnnes Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion pycolmap/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,12 @@ endif()

find_package(colmap REQUIRED)

find_package(Python REQUIRED COMPONENTS Interpreter Development.Module)
if (CMAKE_VERSION VERSION_LESS 3.18)
set(DEV_MODULE Development 5976 )
else()
set(DEV_MODULE Development.Module)
endif()
find_package(Python REQUIRED COMPONENTS Interpreter ${DEV_MODULE} REQUIRED)

find_package(pybind11 2.12.0 REQUIRED)

Expand Down
Loading
0