8000 Robustify nchoosek against overflow by ahojnnes · Pull Request #2706 · colmap/colmap · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Robustify nchoosek against overflow #2706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 13, 2024
Merged

Robustify nchoosek against overflow #2706

merged 2 commits into from
Aug 13, 2024

Conversation

ahojnnes
Copy link
Contributor

Improved implementation that can handle larger values of n and k without overflowing.

@ahojnnes ahojnnes enabled auto-merge (squash) August 13, 2024 12:27
@ahojnnes ahojnnes merged commit 6247ca0 into main Aug 13, 2024
16 checks passed
@ahojnnes ahojnnes deleted the user/joschonb/nchoosek branch August 13, 2024 14:05
@BrewTestBot BrewTestBot mentioned this pull request Nov 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaidusmanu mihaidusmanu mihaidusmanu approved these changes

@sarlinpe sarlinpe Awaiting requested review from sarlinpe

@B1ueber2y B1ueber2y Awaiting requested review from B1ueber2y

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahojnnes @mihaidusmanu
0