8000 Fix table mangled by clang-format by sweber1 · Pull Request #2710 · colmap/colmap · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix table mangled by clang-format #2710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 15, 2024
Merged

Fix table mangled by clang-format #2710

merged 1 commit into from
Aug 15, 2024

Conversation

sweber1
Copy link
Contributor
@sweber1 sweber1 commented Aug 14, 2024

Noticed a table in exe/feature.h was mangled. Happened when clang-format options where simplified in #1950.

This reverts it to what it used to look like:

colmap/src/colmap/exe/feature.h

Lines 44 to 52 in 3947f67

// -----------------------------------------------------------------------------------
// | | ImageReaderOptions |
// | CameraMode | single_camera | single_camera_per_folder | single_camera_per_image |
// |------------|---------------|--------------------------|-------------------------|
// | AUTO | false | false | false |
// | SINGLE | true | false | false |
// | PER_FOLDER | false | true | false |
// | PER_IMAGE | false | false | true |
// -----------------------------------------------------------------------------------
and turns off clang-format for those lines.

@ahojnnes ahojnnes enabled auto-merge (squash) August 15, 2024 05:23
@ahojnnes
Copy link
Contributor

Thanks!

@ahojnnes ahojnnes merged commit 87b57df into colmap:main Aug 15, 2024
16 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Nov 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahojnnes ahojnnes ahojnnes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sweber1 @ahojnnes
0