8000 Improved and simplified caching in feature matching by ahojnnes · Pull Request #2731 · colmap/colmap · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Improved and simplified caching in feature matching #2731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Aug 26, 2024
Merged

Improved and simplified caching in feature matching #2731

merged 12 commits into from
Aug 26, 2024

Conversation

ahojnnes
Copy link
Contributor
@ahojnnes ahojnnes commented Aug 23, 2024 •
edited
Loading
  • Simplifies the caching logic for both CPU and GPU based matching.
  • Introduces a new thread-safe LRU cache that allows to efficiently cache the FLANN-based descriptor index for CPU-based matching. As a result, CPU-based matching speed improves by ~20-30%.
  • Extracts the FLANN-based descriptor index as a separate interface and adds test coverage.
  • Fixes a race-condition in the dense reconstruction workspace cache.

@ahojnnes ahojnnes merged commit 5f653ee into main Aug 26, 2024
16 checks passed
@ahojnnes ahojnnes deleted the user/joschonb/cached-match-index branch August 26, 2024 06:38
@BrewTestBot BrewTestBot mentioned this pull request Nov 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@B1ueber2y B1ueber2y B1ueber2y approved these changes

@sarlinpe sarlinpe Awaiting requested review from sarlinpe

@mihaidusmanu mihaidusmanu Awaiting requested review from mihaidusmanu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahojnnes @B1ueber2y
0