Provide reasonable defaults for some estimator options #2745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Crucial fix. Thanks! |
ahojnnes
approved these changes
Sep 4, 2024
B1ueber2y
reviewed
Sep 4, 2024
| @@ -86,10 +95,10 @@ struct AbsolutePoseRefinementOptions { | |||
| double loss_function_scale = 1.0; | |||
|
|
|||
| // Whether to refine the focal length parameter group. | |||
| bool refine_focal_length = true; | |||
| bool refine_focal_length = false; | |||
There was a problem hiding this comment.
The logic here also needs to be updated since the default has been changed? https://github.com/colmap/colmap/blob/main/src/colmap/sfm/incremental_mapper.cc#L475-L482
Not sure if there are other cases in the sfm. Might need double check
|
|
||
| // Whether to refine the extra parameter group. | ||
| bool refine_extra_params = true; | ||
| bool refine_extra_params = false; |
There was a problem hiding this comment.
Same to the focal_length option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2721 inadvertently broke the default options for
pycolmap.estimate_triangulation, which I then realized were completely wrong. To fix this, I think thatEstimateTriangulationOptionsandAbsolutePose{Estimation,Refinement}Optionsshould provide sensible defaults instead of, as we have been doing it so far, monkey-patching some values in Python. This PR doesn't change the default behavior of COLMAP and only slightly affects PyCOLMAP'sestimate_triangulation/absolute_pose_estimation/rig_absolute_pose_estimationto be consistent with the corresponding COLMAP options.